/agreemsg On Fri, Aug 10, 2018 at 4:02 PM, Sean Owen <sro...@gmail.com> wrote:
> Seems OK to proceed with shutting off lintr, as it was masking those. > > On Fri, Aug 10, 2018 at 6:01 PM shane knapp <skn...@berkeley.edu> wrote: > >> ugh... R unit tests failed on both of these builds. >> https://amplab.cs.berkeley.edu/jenkins//job/ >> SparkPullRequestBuilder/94583/artifact/R/target/ >> https://amplab.cs.berkeley.edu/jenkins//job/ >> SparkPullRequestBuilder/94584/artifact/R/target/ >> >> >> >> On Fri, Aug 10, 2018 at 1:58 PM, Shivaram Venkataraman < >> shiva...@eecs.berkeley.edu> wrote: >> >>> Sounds good to me as well. Thanks Shane. >>> >>> Shivaram >>> On Fri, Aug 10, 2018 at 1:40 PM Reynold Xin <r...@databricks.com> wrote: >>> > >>> > SGTM >>> > >>> > On Fri, Aug 10, 2018 at 1:39 PM shane knapp <skn...@berkeley.edu> >>> wrote: >>> >> >>> >> https://issues.apache.org/jira/browse/SPARK-25089 >>> >> >>> >> basically since these branches are old, and there will be a greater >>> than zero amount of work to get lint-r to pass (on the new ubuntu workers), >>> sean and i are proposing to remove the lint-r checks for the builds. >>> >> >>> >> this is super not important for the 2.4 cut/code freeze, but i wanted >>> to get this done before it gets pushed down my queue and before we revisit >>> the ubuntu port. >>> >> >>> >> thanks in advance, >>> >> >>> >> shane >>> >> -- >>> >> Shane Knapp >>> >> UC Berkeley EECS Research / RISELab Staff Technical Lead >>> >> https://rise.cs.berkeley.edu >>> >> >> >> >> -- >> Shane Knapp >> UC Berkeley EECS Research / RISELab Staff Technical Lead >> https://rise.cs.berkeley.edu >> > -- Shane Knapp UC Berkeley EECS Research / RISELab Staff Technical Lead https://rise.cs.berkeley.edu
