There’s already a code style guide listed on http://spark.apache.org/contributing.html. Maybe it’s the same? We should decide which one we actually want and update this page if it’s wrong.
Matei > On Aug 23, 2018, at 6:33 PM, Sean Owen <sro...@gmail.com> wrote: > > Seems OK to me. The style is pretty standard Scala style anyway. My guidance > is always to follow the code around the code you're changing. > > On Thu, Aug 23, 2018 at 8:14 PM Hyukjin Kwon <gurwls...@gmail.com> wrote: > Hi all, > > I usually follow https://github.com/databricks/scala-style-guide for Apache > Spark's style, which is usually generally the same with the Spark's code base > in practice. > Thing is, we don't explicitly mention this within Apache Spark as far as I > can tell. > > Can we explicitly mention this or port this style guide? It doesn't > necessarily mean hard requirements for PRs or code changes but we could at > least encourage people to read it. > --------------------------------------------------------------------- To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
