This has already helped me catch a potential flaky test I might have otherwise missed. So excited for this additional signal :)
On Tue, Jul 14, 2020 at 6:19 PM Takeshi Yamamuro <linguin....@gmail.com> wrote: > Thanks, Hyukjin! > > > Therefore, I do believe PRs can be merged in most general cases once the > Jenkins PR > builder or Github Actions build passes > > greatly helpful! > > Bests, > Takeshi > > On Tue, Jul 14, 2020 at 4:14 PM Hyukjin Kwon <gurwls...@gmail.com> wrote: > >> Perfect. Plus, Github Actions is only for master branch at this moment. >> >> BTW, I think we can enable Java(Scala) doc build and dependency test back >> in Jenkins for simplicity. >> Seems like the Jenkins machine came back to normal. >> >> 2020년 7월 14일 (화) 오후 4:08, Wenchen Fan <cloud0...@gmail.com>님이 작성: >> >>> To clarify, we need to wait for: >>> 1. Java documentation build test in github actions >>> 2. dependency test in github actions >>> 3. either github action all green or jenkin pass >>> >>> If the PR touches Kinesis, or it uses other profiles, we must wait for >>> jenkins to pass. >>> >>> Do I miss something? >>> >>> On Tue, Jul 14, 2020 at 2:18 PM Hyukjin Kwon <gurwls...@gmail.com> >>> wrote: >>> >>>> Hi dev, >>>> >>>> Github Actions build was introduced to run the regular Spark test cases >>>> at https://github.com/apache/spark/pull/29057and >>>> https://github.com/apache/spark/pull/29086. >>>> This is virtually the duplication of default Jenkins PR builder at this >>>> moment. >>>> >>>> The only differences are: >>>> - Github Actions does not run the tests for Kinesis, see SPARK-32246 >>>> - Github Actions does not support other profiles such as JDK 11 or Hive >>>> 1.2, see SPARK-32255 >>>> - Jenkins build does not run Java documentation build, see SPARK-32233 >>>> - Jenkins build does not run the dependency test, see SPARK-32178 >>>> >>>> Therefore, I do believe PRs can be merged in most general cases once >>>> the Jenkins PR >>>> builder or Github Actions build passes when we expect the successful >>>> test results from >>>> the default Jenkins PR builder. >>>> >>>> Thanks. >>>> >>> > > -- > --- > Takeshi Yamamuro > -- Twitter: https://twitter.com/holdenkarau Books (Learning Spark, High Performance Spark, etc.): https://amzn.to/2MaRAG9 <https://amzn.to/2MaRAG9> YouTube Live Streams: https://www.youtube.com/user/holdenkarau
