I personally like this idea. At least we now do this in PySpark, and it's pretty nice that you can just forget about formatting it manually by yourself.
On Fri, 14 Oct 2022 at 16:37, Martin Grund <martin.gr...@databricks.com.invalid> wrote: > Hi folks, > > I'm reaching out to ask to gather input / consensus on the following > proposal: Since Spark Connect is effectively new code, I would like to > enforce scalafmt explicitly *only* on this module by adding a check in > `dev/lint-scala` that checks if there is a diff after running > > ./build/mvn -Pscala-2.12 scalafmt:format -Dscalafmt.skip=false -pl > connector/connect > > I know that enforcing scalafmt is not desirable on the existing code base > but since the Spark Connect code is very new I'm thinking it might reduce > friction in the code reviews and create a consistent style. > > In my previous code reviews where I have applied scalafmt I've > received feedback on the import grouping that scalafmt is changing > different from our default style. I've prepared a PR > https://github.com/apache/spark/pull/38252 to address this issue by > explicitly setting it in the scalafmt option. > > Would you be supportive of enforcing scalafmt *only* on the Spark Connect > module? > > Thanks > Martin >
