[ http://issues.apache.org/struts/browse/SHALE-87?page=all ]
Craig McClanahan moved STR-2591 to SHALE-87: -------------------------------------------- Project: Shale (was: Struts Action 1) Key: SHALE-87 (was: STR-2591) Component: (was: Shale) Version: (was: Nightly Build) Assign To: (was: Struts Developer Mailing List) > [shale] AbstractFacesBean message methods don't use the UIComponent parameter > ----------------------------------------------------------------------------- > > Key: SHALE-87 > URL: http://issues.apache.org/struts/browse/SHALE-87 > Project: Shale > Type: Bug > Environment: Operating System: other > Platform: Other > Reporter: Ronald Holshausen > Priority: Minor > > I've noticed that the AbstractFacesBean have a number of message methods > (info, > error, warn, fatal) that take a UIComponent parameter, but they don't use it. > Class: org.apache.shale.view.AbstractFacesBean > Lines: 223-347 > The current implementation is (for the info method): > protected void info(UIComponent component, String summary) { > getFacesContext().addMessage(null, > new FacesMessage(FacesMessage.SEVERITY_INFO, summary, null)); > } > and I'm assuming it should be something like: > protected void info(UIComponent component, String summary) { > FacesContext facesContext = getFacesContext(); > facesContext.addMessage(component.getClientId(facesContext), > new FacesMessage(FacesMessage.SEVERITY_INFO, summary, null)); > } > This pattern is the same for warn, error and fatal methods that take a > UIComponent parameter. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]