[
https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420278#comment-16420278
]
Christian Weiss commented on THRIFT-4535:
-----------------------------------------
Thank you for your quick responses!
{quote}Why don't you just submit a pull request to merge both into one? Can't
be too hard, right?
{quote}
This sounds a bit cynical - one shouldn't just drop a huge "this changes
everything"-PR without talking about it first, right? :) I made this statement
because "csharp" and "netcore" are advertised as different languages in several
places ([https://github.com/apache/thrift/blob/master/README.md,]
[https://github.com/apache/thrift/blob/master/LANGUAGES.md]) and this has not
been done for any other language.
{quote}I believe this was an attempt to rewrite some of the fundamentals
including threads and asynchronous behavior. We should identify what, if
anything, is in the csharp project that should be carried forward. It is
probably reasonable to use the current netcore as a starting point.
{quote}
This sounds like a good plan! What is your policy on backwards compatibility
and supported .NET framework/platforms versions? If there were just one code
base, would you still want to support Silverlight (Official Microsoft support
will end in 2021) and .NET framework versions older than 4.5 in this new
release?
Is it correct that there's no official nuget.org package for "netcore" yet? As
the "netcore" library/package is also called "Thrift" was it the plan to
replace the existing "Thrift" package (based on "csharp") on nuget.org anyway
or should this be released under a different name?
> Current state and future of .NET libraries ("csharp" and "netcore")?
> --------------------------------------------------------------------
>
> Key: THRIFT-4535
> URL: https://issues.apache.org/jira/browse/THRIFT-4535
> Project: Thrift
> Issue Type: Question
> Components: C# - Library, netcore - Library
> Reporter: Christian Weiss
> Priority: Major
>
> Hi,
> We are trying to use Thrift in one of our projects but we ran into some very
> fundamental issues:
> * The "csharp" project does not target ".NET Standard" and there's only a
> very old release on nuget.org ( if [https://www.nuget.org/packages/Thrift/]
> is the official one).
> * The "netcore" project does target ".NET Standard" but there's no release
> yet ( https://issues.apache.org/jira/browse/THRIFT-4512 ) and it also has a
> dependency on ASP.NET Core (
> https://issues.apache.org/jira/browse/THRIFT-4534 ) which makes it unusable
> in non-web projects.
> I'm wondering why there even are 2 separate projects for .NET? It's important
> to understand that ".NET Core" is not a new programming API - It's just a new
> platform - very similar to Silverlight, Mono, Windows Phone. This means that
> it would also be possible to support .NET Core and the new ".NET Standard"
> (which represents a common set of APIs for all platforms) with the existing
> "csharp" project.
> Was this a deliberate decision - e.g. to make the "netcore" code the official
> successor of the "csharp" code?
> Would you be interested in merging the code back into one library? I'd be
> willing to help if you want!
> It would be great to get one proper, up to date and official .NET library
> soon as there's already quite a lot of weird forks on NuGet.org:
> https://www.nuget.org/packages?q=Thrift
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
