[ https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733820#comment-16733820 ]
Brian Nixon commented on ZOOKEEPER-3232: ---------------------------------------- seems reasonable to me > make the log of notification about LE more readable > --------------------------------------------------- > > Key: ZOOKEEPER-3232 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3232 > Project: ZooKeeper > Issue Type: Improvement > Components: leaderElection > Reporter: maoling > Assignee: maoling > Priority: Minor > > the log of notification about LE is very important to help us to see the > process of LE:e.g. > {code:java} > 2019-01-01 16:29:27,494 [myid:2] - INFO > [WorkerReceiver[myid=2]:FastLeaderElection@595] - Notification: 1 (message > format version), 3 (n.leader), 0x60b3dc215 (n.zxid), 0x3 (n.round), FOLLOWING > (n.state), 1 (n.sid), 0x7 (n.peerEpoch) LOOKING (my state){code} > the current log have some problems: > 1:don't use the placeholder(other:+),don't in the style of k:v(antiman) > 2.the properties in the logs are very messed(no group by,no order), not easy > to read. > 3.the value about version is HEX which don't have the 0x prefix. -- This message was sent by Atlassian JIRA (v7.6.3#76005)