Finally got around to looking at this issue. https://github.com/apache/zookeeper/pull/996 may suffice to address the breaking test.
On Wed, Jan 30, 2019 at 2:39 PM Brian Nixon <brian.nixon...@gmail.com> wrote: > ZOOKEEPER-3240 is my patch - I'll see if I can figure out what the problem > is. > > > On Wed, Jan 30, 2019 at 7:54 AM Andor Molnar <an...@cloudera.com.invalid> > wrote: > >> This doesn't look good yet. >> Let's give it some time (til tomorrow) to recover. >> >> Andor >> >> >> >> On Wed, Jan 30, 2019 at 12:08 PM Andor Molnar <an...@cloudera.com> wrote: >> >> > Done. I reverted the patch on 3.5 and master branches. >> > Hopefully builds will soon become green again. >> > >> > Andor >> > >> > >> > >> > On Wed, Jan 30, 2019 at 11:45 AM Andor Molnar <an...@cloudera.com> >> wrote: >> > >> >> 2 tests are failing constantly: >> >> >> >> >> >> >> org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss >> >> >> >> >> org.apache.zookeeper.server.quorum.ReconfigFailureCasesTest.testLeaderTimesoutOnNewQuorum >> >> >> >> I reverted "ZOOKEEPER-3240: Close socket on Learner shutdown to avoid >> >> dangling socket" and now it works. >> >> >> >> Andor >> >> >> >> >> >> >> >> On Wed, Jan 30, 2019 at 11:43 AM Enrico Olivelli <eolive...@gmail.com> >> >> wrote: >> >> >> >>> Do you have failing tests or code does not compile at all? (I don't >> have >> >>> my >> >>> laptop at the moment) >> >>> >> >>> Enrico >> >>> >> >>> Il giorno mer 30 gen 2019, 11:31 Andor Molnar >> <an...@cloudera.com.invalid >> >>> > >> >>> ha scritto: >> >>> >> >>> > Hi team, >> >>> > >> >>> > Looks like one of these changes have broken the build: >> >>> > >> >>> > >> >>> > 1. ZOOKEEPER-3250 < >> >>> https://issues.apache.org/jira/browse/ZOOKEEPER-3250 >> >>> > >: >> >>> > typo in doc - zookeeperInternals (detail >> >>> > < >> >>> > >> >>> >> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail0 >> >>> > > >> >>> > ) >> >>> > 2. ZOOKEEPER-3256 < >> >>> https://issues.apache.org/jira/browse/ZOOKEEPER-3256 >> >>> > >: >> >>> > Enable OWASP checks to Maven build (detail >> >>> > < >> >>> > >> >>> >> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail1 >> >>> > > >> >>> > ) >> >>> > 3. Fix typos (detail >> >>> > < >> >>> > >> >>> >> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail2 >> >>> > > >> >>> > ) >> >>> > 4. ZOOKEEPER-3236 < >> >>> https://issues.apache.org/jira/browse/ZOOKEEPER-3236 >> >>> > >: >> >>> > Upgrade BouncyCastle (detail >> >>> > < >> >>> > >> >>> >> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail3 >> >>> > > >> >>> > ) >> >>> > 5. ZOOKEEPER-3240 < >> >>> https://issues.apache.org/jira/browse/ZOOKEEPER-3240 >> >>> > >: >> >>> > Close socket on Learner shutdown to avoid dangling so… (detail >> >>> > < >> >>> > >> >>> >> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_jdk8/1285/changes#detail4 >> >>> > > >> >>> > ) >> >>> > >> >>> > I'm trying to revert them one-by-one and see which one is the bad >> guy. >> >>> > >> >>> > Regards, >> >>> > Andor >> >>> > >> >>> >> >> >> >
