On Mon, Feb 24, 2020, 18:38 Miro Hrončok <mhron...@redhat.com> wrote:
> On 24. 02. 20 17:48, Pierre-Yves Chibon wrote: > > However, for the release field, we are struggling a little bit more, two > options > > are more appealing to us: > > Can we please have a "git is the only source of truth" version of this? > I.e. > "Compute the release field from the number of commits since the last > version > change" in the document. It seem to only have one con (breaks if two > builds are > triggered from the same commit) which is the status quo. > > If you need to rebuild for a libpingouisawesome soname bump, you just do > an > empty commit with the explanation. > > If you merge that empty commit to a branch that did not need it, it would > have a > bogus changelog entry (status quo). If you care, you would not merge but > cherry-pick anything thta comes next (which is now much easier given the > benefit > of not having the %changelog and release). > > With the proposed solution that includes "successful build count" you > always > bump and build even if it is not needed and also you make the release > number > depend on a specific build system, which I think is kinda wrong. > > i.e. if you do two "fedpkg build" in a row without a commit, I think that > the > second one should still fail with "already been build" kind of message. > What if build environment has changed? > -- > Miro Hrončok > -- > Phone: +420777974800 > IRC: mhroncok > _______________________________________________ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org >
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
