On Thu, 13 Aug 2020 18:41:23 +0800, Qiyu Yan wrote: > In the latest version of rpmdevtools, rpmdev-bumpspec has changed to > use time+date in the changelog it generates[1], while the packaging > guidelines have not been updated accordingly[2], should the guideline > be updated to the rpmdev-bumpspec change?
The git commit message for that change is vague, since it only refers to an RPM version but doesn't sum up what the goal of this change is. > I am packaging fcitx5 using forge macros, and upstream have never > tagged a version, in this case, I am packaging like this [3] (The > snapshot dates and git short commit hashesin changelog is manually > added). With this spec file, I noticed that when I try to use > rpmdev-bumpspec to generate a changelog, it will give things like this > [4]. The forge macros you use mess with %dist, which is highly questionable. The rpmdev-bumpspec script itself doesn't evaluate any RPM macros. It only recognizes a variety of version/release schemes used by Fedora. For the %changelog comment, it relies on an "rpm" command-line call in order to determine the full E:VR for the %changelog entry. Since %dist is not to be included in %changelog comments, %dist gets undefined, but then the %forge macro stuff is lost. As a side-note: The E:V-R details right of the email address in changelog comments are not everyone's cup of tea. They are not mission critical but optional. If truncated, they don't break the rpmbuild. In your case, V-R is complete and accurate. The left most-significant part of %release is included in the V-R and is sufficient, and while the git commit hash is missing, it is just noise in changelog comments. _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
