On 10/11/2021 21:15, Globe Trotter via devel wrote:
Version: %ver
Release: %rel

You shouldn't use macroses here, because this behavior can break release bumps from different bots or proven-packager scripts.

Group: Applications/Communications

Legacy. Must be removed.

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-%(%{__id_u} -n)

Must be removed.

%setup -q

Can be replaced with %autosetup.

%{?ldconfig_scriptlets}

No longer used. Can be removed.

%defattr(-,root,root,-)

Legacy. Must be removed.

%clean
rm -rf %{buildroot}

Not allowed by modern Fedora guidelines. Must be removed.

--
Sincerely,
  Vitaly Zaitsev (vit...@easycoding.org)
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to