On ke, 22 joulu 2021, Alexander Bokovoy wrote:
On ke, 22 joulu 2021, Mat Booth wrote:
On Tue, 21 Dec 2021 at 14:35, Alexander Bokovoy <aboko...@redhat.com> wrote:

I picked up wsdl4j to prevent actions which would lead to tomcat, Dogtag, and
FreeIPA being orphaned over Christmas break.


Have you tried building tomcat without wsdl? I can't see where in the
tomcat source it is used. Is it really a build dep?

I haven't tried that yet.

Looking at the spec, ant is called with
 -Dwsdl4j-lib.jar="$(build-classpath wsdl4j)" \

Looking at the tomcat source code, there are plenty of references to
WSDL code, so it is definitely needed at runtime because WSDL
definitions for servlets are parsed and used. Build environment insists
on having WSDL jars in the class path (in build.xml):

 <path id="compile.classpath">
   <pathelement location="${bnd.jar}"/>
   <pathelement location="${osgi-annotations.jar}"/>
   <pathelement location="${jdt.jar}"/>
   <pathelement location="${jaxrpc-lib.jar}"/>
   <pathelement location="${wsdl4j-lib.jar}"/>
 </path>

I did a quick test in mock for rawhide by removing BuildRequires for
wsdl4j and the build succeeded with only one warning that wsdl4j jar was
not found:

$ grep wsdl results_tomcat/9.0.56/1.fc36/build.log
++ build-classpath wsdl4j
/usr/bin/build-classpath: Could not find wsdl4j Java extension for this JVM
+ ant -Dbase.path=. -Dbuild.compiler=modern -Dcommons-daemon.jar=HACK 
-Dcommons-daemon.native.src.tgz=HACK -Djdt.jar=/usr/share/java/ecj/ecj.jar 
-Dtomcat-native.tar.gz=HACK -Dtomcat-native.home=. 
-Dcommons-daemon.native.win.mgr.exe=HACK -Dnsis.exe=HACK -Djaxrpc-lib.jar=HACK 
-Dwsdl4j-lib.jar= -Dbnd.jar=/usr/share/java/aqute-bnd/biz.aQute.bnd.jar 
-Dbndlib.jar=/usr/share/java/aqute-bnd/biz.aQute.bndlib.jar 
-Dbndlibg.jar=/usr/share/java/aqute-bnd/aQute.libg.jar 
-Dbndannotation.jar=/usr/share/java/aqute-bnd/biz.aQute.bnd.annotation.jar 
-Dosgi-annotations.jar=/usr/share/java/aqute-bnd/biz.aQute.bnd.annotation.jar 
-Dslf4j-api.jar=/usr/share/java/slf4j/slf4j-api.jar 
-Dosgi-cmpn.jar=/usr/share/java/osgi-compendium/osgi.cmpn.jar -Dversion=9.0.56 
-Dversion.build=56 deploy

I haven't run the resulting package with a real life workload, though.


--
/ Alexander Bokovoy
Sr. Principal Software Engineer
Security / Identity Management Engineering
Red Hat Limited, Finland
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to