On 01/26/2016 12:48 AM, Ville Skyttä wrote:
On Tue, Jan 26, 2016 at 9:35 AM, Petr Pisar <ppi...@redhat.com> wrote:
This can bring bugs because, as noted in the orignal message, some
people use to change wrong permissions coming from %install section.
Can you give a concrete example where doing this actually accomplishes
something with rpmbuild >= 4.4? I can't immediately think of one; I
don't see how "wrong permissions from %install" would end up in the
package as files with non-root user/group. AFAIU rpmbuild >= 4.4 sets
%defattr(-,root,root,-) by default and repeating immediately at start
of %files is a no-op.
Ville is right: the move away from %defattr was done 5 years ago(!)
already. As speculated by Jason in the original post, %defattr *was*
necessary for EL4, but seems to be unnecessary in EL5 and newer.
In my case, the use of %defattr has just been a lapse - I thought it was
still necessary for EL5.
I'm all for a script based approach to remove the default %defattr
statements from spec files.
--
Susi Lehtola
Fedora Project Contributor
jussileht...@fedoraproject.org
--
devel mailing list
devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
