Hi Adrian, In that case, your best bet is opening an issue with what you wrote here at:
https://github.com/ClusterLabs/resource-agents/issues On Wed, 2023-06-14 at 13:17 +0000, Golding, Adrian (Senior Database Engineer) wrote: > Hi Ken, > > I had a look there and it just confused the heck out of me. I don’t > think a pull request is for me. I'll just explain my issue/query and > maybe you can post it on somewhere or let me know how and where I > should... > > Here we go: - > > When you create an Oracle Listener (oralsnr) resource with "pcs > resource create", one of the parameters it requires is "sid" and the > documentation asks you to enter the ORACLE_SID for that. > > I think this should be changed to ask for a "TNS Entry" because... > > 1) All the oralsnr script does is tnsping that value so we should be > able to call it what we want and create an appropriate tnsnames.ora > entry for it. > 2) Using the ORACLE_SID is not ideal as there may already be a > tnsnames.ora entry bearing that name and using it for dual purposes > is dangerous (what if someone decided it was no longer required and > removed it?). > 3) It makes no sense to use the ORACLE_SID, that is the database > identifier. This is the listener so if anything the listener name > would be more appropriate. > > In practice there doesn't seem to be any problem setting any desired > value for "sid". I have been using the listener name as it makes > more sense and I can then have a dedicated tnsnames.ora entry with > that name (it can be a simple one without any connect data clause as > nobody/nothing will be using it for a database connection) therefore > avoiding any risk of it being accidently removed or of it being used > for other purposes. > > My problem is, people are averse to doing this because it goes > against what the documentation says, despite the fact it makes much > more sense to do as I have described above. > > Therefore, I think this is really just a documentation issue and I > think it should be amended to state that "sid" should be the name of > a (dedicated) tnsnames.ora entry for the service to tnsping. > > Cheers, > Adrian. > > > -----Original Message----- > From: Ken Gaillot <kgail...@redhat.com> > Sent: Monday, June 12, 2023 2:32 PM > To: developers@clusterlabs.org > Cc: Golding, Adrian (Senior Database Engineer) <adrian.gold...@sky.uk > > > Subject: [EXTERNAL] Re: [ClusterLabs Developers] Pacemaker scripts > for Oracle > > On Fri, 2023-06-09 at 08:14 +0000, Golding, Adrian (Senior Database > Engineer) via Developers wrote: > > Hi, > > > > I would like to ask how I get approach a documentation enhancement > > for > > the "oralsnr" pacemaker script. > > Hi Adrian, > > That is part of the resource-agents project. You can file a pull > request at: > > https://github.com/ClusterLabs/resource-agents > > > I won’t explain here as I’m not sure I am emailing the correct > > address > > but am happy to explain if I get a response to this. > > > > Cheers, > > Adrian. > > > > Adrian Golding > > Senior Database Engineer > > Technology Services > > Comms & Infrastructure > > > > Sky UK > > Email: adrian.gold...@sky.uk > > Desk: +44 207 032 7523 > > > > Information in this email including any attachments may be > > privileged, > > confidential and is intended exclusively for the addressee. The > > views > > expressed may not be official policy, but the personal views of the > > originator. If you have received it in error, please notify the > > sender > > by return e-mail and delete it from your system. You should not > > reproduce, distribute, store, retransmit, use or disclose its > > contents > > to anyone. Please note we reserve the right to monitor all e-mail > > communication through our internal and external networks. SKY and > > the > > SKY marks are trademarks of Sky Limited and Sky International AG > > and > > are used under licence. > > > > Sky UK Limited (Registration No. 2906991), Sky-In-Home Service > > Limited > > (Registration No. 2067075), Sky Subscribers Services Limited > > (Registration No. 2340150) and Sky CP Limited (Registration No. > > 9513259) are direct or indirect subsidiaries of Sky Limited > > (Registration No. 2247735). All of the companies mentioned in this > > paragraph are incorporated in England and Wales and share the same > > registered office at Grant Way, Isleworth, Middlesex TW7 5QD > > _______________________________________________ > > Manage your subscription: > > https://lists.clusterlabs.org/mailman/listinfo/developers > > > > ClusterLabs home: https://www.clusterlabs.org/ > -- > Ken Gaillot <kgail...@redhat.com> > > -------------------------------------------------------------------- > This email is from an external source. Please do not open attachments > or click links from an unknown or suspicious origin. Phishing > attempts can be reported by using the report message button in > Outlook or sending them as an attachment to phish...@sky.uk. Thank > you > -------------------------------------------------------------------- > > Information in this email including any attachments may be > privileged, confidential and is intended exclusively for the > addressee. The views expressed may not be official policy, but the > personal views of the originator. If you have received it in error, > please notify the sender by return e-mail and delete it from your > system. You should not reproduce, distribute, store, retransmit, use > or disclose its contents to anyone. Please note we reserve the right > to monitor all e-mail communication through our internal and external > networks. SKY and the SKY marks are trademarks of Sky Limited and Sky > International AG and are used under licence. > > Sky UK Limited (Registration No. 2906991), Sky-In-Home Service > Limited (Registration No. 2067075), Sky Subscribers Services Limited > (Registration No. 2340150) and Sky CP Limited (Registration No. > 9513259) are direct or indirect subsidiaries of Sky Limited > (Registration No. 2247735). All of the companies mentioned in this > paragraph are incorporated in England and Wales and share the same > registered office at Grant Way, Isleworth, Middlesex TW7 5QD -- Ken Gaillot <kgail...@redhat.com> _______________________________________________ Manage your subscription: https://lists.clusterlabs.org/mailman/listinfo/developers ClusterLabs home: https://www.clusterlabs.org/