On Fri, Feb 02, 2024 at 02:01:47PM +0530, Kolanupaka Naveena wrote: > +#ifdef BPM_MODULE_IMPORT_NS_SUPPORT > +#include <linux/module.h> > +#endif
No #ifdef in .c files please, this should not be an issue, just include the .h file. > #include <drm/intel_iaf_platform.h> > > #include "gem/i915_gem_dmabuf.h" > @@ -23,6 +26,10 @@ > #include "i915_trace.h" > #include "intel_iaf.h" > > +#ifdef BPM_MODULE_IMPORT_NS_SUPPORT > +MODULE_IMPORT_NS(DMA_BUF); > +#endif Why is a #ifdef needed here? If this isn't built as a module, it's not an issue, please just make it simpler. But really, why is this a #define at all in the first place? thanks, greg k-h
