On Thu, May 9, 2024 at 9:28 AM Doug Anderson <diand...@chromium.org> wrote: > > Hi, > > On Tue, May 7, 2024 at 4:05 PM Abhinav Kumar <quic_abhinavk@quicinccom> wrote: > > > > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from > > Mesa"), > > compilation is broken on machines having python versions older than 3.9 > > due to dependency on argparse.BooleanOptionalAction. > > > > Switch to use simple bool for the validate flag to remove the dependency. > > > > Fixes: 5acf49119630 ("drm/msm: import gen_header.py script from Mesa") > > Signed-off-by: Abhinav Kumar <quic_abhin...@quicinc.com> > > --- > > drivers/gpu/drm/msm/registers/gen_header.py | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > No idea if we're supposed to allow python as a build dependency. That > being said, I can confirm that this fixes the problem for me since I > ran into it too [1]. > > Tested-by: Douglas Anderson <diand...@chromium.org> > > [1] > https://lore.kernel.org/r/CAD=FV=XnpS-=cookkxzfm8og9wcsemxfesmftyh811438qg...@mail.gmail.com >
I do not like Perl. IMHO, Python should be OK if Perl is OK. I agree that the required version should be documented changes.rst, at least. -- Best Regards Masahiro Yamada