On Mon, Oct 22, 2012 at 1:26 PM, Vincent Torri <vincent.to...@gmail.com> wrote: > On Mon, Oct 22, 2012 at 4:57 PM, Lucas De Marchi > <lucas.demar...@profusion.mobi> wrote: >> On Sun, Oct 21, 2012 at 2:53 AM, Enlightenment SVN >> <no-re...@enlightenment.org> wrote: >>> Log: >>> edbus: Add initializers to stop warnings >>> >>> Author: englebass >>> Date: 2012-10-20 21:52:59 -0700 (Sat, 20 Oct 2012) >>> New Revision: 78292 >>> Trac: http://trac.enlightenment.org/e/changeset/78292 >>> >>> Modified: >>> trunk/edbus/src/lib/edbus_service.h >>> >>> Modified: trunk/edbus/src/lib/edbus_service.h >>> =================================================================== >>> --- trunk/edbus/src/lib/edbus_service.h 2012-10-21 04:25:32 UTC (rev 78291) >>> +++ trunk/edbus/src/lib/edbus_service.h 2012-10-21 04:52:59 UTC (rev 78292) >>> @@ -24,7 +24,7 @@ >>> * The signature will be "ss" and each string will have a tag name on >>> * introspect XML with the respective name. >>> */ >>> -#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { } } >>> +#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { NULL, NULL } >>> } >> >> Nah... wrong fix. We don't use this warning on EDBus on purpose. > > what about explaning that "purpose" ?
This is allowed in C and that warning flag doesn't make sense at all. If we ever extend EDBus_Arg_Info, we would need to keep adding NULLs here. Look what that insanity pushes we to: EWK_VIEW_SMART_CLASS_INIT in http://searchco.de/codesearch/view/10001195 Currently it contains 37 zeros (and counting...)!! http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_view.h#L215 Although I don't envision such a change in EDBus_Arg_Info any time soon, we heavily rely on this in other places and patches "fixing warnings" like this have no benefit. Lucas De Marchi ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
