[please keep CC to debian-forensics mailing list]

Hi Simson,

my name is Cristian Greco, I'm a debian maintainer involved in the Debian
Forensics Team (I'm sure you already know Christophe Monniez and Michael
Prokop).

I started working on the afflib package, and I'd like to hear your opinion on
two patches attached to this mail:

 * 03-bashism.patch, fixes a so-called bashism in a test script.

 * 04-fix-afdiskprint.patch, fixes a grave bug which prevents afdiskprint from
   starting at all!

Do you think these patches could be merged in your official release?

I hope we can start cooperating for a better packaging and release work! :-)

Thanks,
--
Cristian Greco
GPG key ID: 0xCF4D32E4 (old: 0x0C095825)
Author: Christophe Monniez <christophe.monn...@fccu.be>
Description: fix some bashisms detected by checkbashisms script.

--- a/tools/test_make_random_iso.sh
+++ b/tools/test_make_random_iso.sh
@@ -5,7 +5,7 @@
 
 unset AFFLIB_PASSPHRASE
 
-if [ x"" = x$1 ] ; 
+if test "x" = "x$1" ;
   then echo usage: $0 filename
   exit 1
 fi
Author: Cristian Greco <crist...@regolo.cc>
Description: fix libexpat detection in afdiskprint.

--- a/tools/afdiskprint.cpp
+++ b/tools/afdiskprint.cpp
@@ -30,7 +30,7 @@
 #include "base64.h"
 #include "hashextent.h"
 
-#ifdef HAVE_EXPAT
+#ifdef HAVE_LIBEXPAT
 
 #include <openssl/evp.h>
 

Attachment: signature.asc
Description: PGP signature

_______________________________________________
forensics-devel mailing list
forensics-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/forensics-devel

Reply via email to