[Bug rust/114629] rust-ast-resolve-expr contains bloated code for funny_error

[pinskia at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114629

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-04-07
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |diagnostic

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

  else if (funny_error)
    {
      /* This was a "break rust" or "break gcc", and the identifier failed to
         resolve.  Emit a funny ICE.  We set the finalizer to our custom one,
         and use the lower-level emit_diagnostic () instead of the more common
         internal_error_no_backtrace () in order to pass our locus.  */
      diagnostic_finalizer (global_dc) = funny_ice_finalizer;
      emit_diagnostic (DK_ICE_NOBT, expr.get_locus (), -1,
                       "are you trying to break %s? how dare you?",
                       expr.as_string ().c_str ());

This is not even that funny.
I suggest to remove the idea of funny_error really.
          if (ident == "rust" || ident == "gcc")
            funny_error = true;

...