On Dec 10, 2021, Jeff Law <jeffreya...@gmail.com> wrote: > The patch is clearly safe. My question is should we have caught this > earlier in the call chain?
Callers will call try_store_by_multiple_pieces if set_storage_via_setmem fails. setmem doesn't necessarily need min and max len to do its job, so if we were to modify callers, it would be just guarding the calls of try_store_by_multiple_pieces with max_len >= min_len: 3 callers in 2 files, which didn't seem appealing to me. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about <https://stallmansupport.org>
