Hi Thomas,
On 01.04.23 10:42, Thomas Schwinge wrote:
... I see FAIL for x86_64-pc-linux-gnu '-m32' (thus, host, not
offloading), '-O0' (only):
[...]
FAIL: libgomp.fortran/loop-transforms/unroll-1.f90 -O0 execution test
[...]
FAIL: libgomp.fortran/loop-transforms/unroll-simd-1.f90 -O0 execution
test
Thank you for reporting the failures! They are caused by mistakes in the
test code, not the implementation. I have attached a patch which fixes
the failures.
I have been able to reproduce the failures with -m32. With the patch
they went away, even with 100 of repeated test executions ;-).
Best regards,
Frederik
From 3f471ed293d2e97198a65447d2f0d2bb69a2f305 Mon Sep 17 00:00:00 2001
From: Frederik Harwath <frede...@codesourcery.com>
Date: Thu, 6 Apr 2023 14:52:07 +0200
Subject: [PATCH] openmp: Fix loop transformation tests
libgomp/ChangeLog:
* testsuite/libgomp.fortran/loop-transforms/tile-2.f90: Add reduction clause.
* testsuite/libgomp.fortran/loop-transforms/unroll-1.f90: Initialize var.
* testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90: Add reduction
and initialization.
---
libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90 | 2 +-
libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90 | 2 ++
.../libgomp.fortran/loop-transforms/unroll-simd-1.f90 | 3 ++-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90 b/libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90
index 6aedbf4724f..a7cb5e7635d 100644
--- a/libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90
+++ b/libgomp/testsuite/libgomp.fortran/loop-transforms/tile-2.f90
@@ -69,7 +69,7 @@ module test_functions
integer :: i,j
sum = 0
- !$omp parallel do collapse(2)
+ !$omp parallel do collapse(2) reduction(+:sum)
!$omp tile sizes(6,10)
do i = 1,10,3
do j = 1,10,3
diff --git a/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90 b/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90
index f07aab898fa..b91ea275577 100644
--- a/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90
+++ b/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-1.f90
@@ -8,6 +8,7 @@ module test_functions
integer :: i,j
+ sum = 0
!$omp do
do i = 1,10,3
!$omp unroll full
@@ -22,6 +23,7 @@ module test_functions
integer :: i,j
+ sum = 0
!$omp parallel do reduction(+:sum)
!$omp unroll partial(2)
do i = 1,10,3
diff --git a/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90 b/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90
index 5fb64ddd6fd..7a43458f0dd 100644
--- a/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90
+++ b/libgomp/testsuite/libgomp.fortran/loop-transforms/unroll-simd-1.f90
@@ -9,7 +9,8 @@ module test_functions
integer :: i,j
- !$omp simd
+ sum = 0
+ !$omp simd reduction(+:sum)
do i = 1,10,3
!$omp unroll full
do j = 1,10,3
--
2.36.1
