On 26/02/2024 16:05, Wilco Dijkstra wrote:
> Hi Richard,
>
>> Did you test this on a thumb1 target? It seems to me that the target parts
>> that you've
>> removed were likely related to that. In fact, I don't see why this test
>> would need to be changed at all.
>
> The testcase explicitly forces a Thumb-2 target (arm_arch_v6t2). The patterns
> were wrong for Thumb-2 indeed, and the testcase was explicitly testing for
> this.
> There is a separate builtin-bswap-2.c for Thumb-1 target (arm_arch_v6m).
>
> Cheers,
> Wilco
That's why statements like:
* gcc.target/arm/builtin-bswap-1.c: Fix test.
are less than helpful. Perhaps if you'd said what you actually changed that
would have made it more obvious.
So OK, but please fix the commit message to say what you did.
R.
