On Mon, 18 Mar 2024 at 22:35, Evgeny Karpov <evgeny.kar...@microsoft.com> wrote: > > Monday, March 18, 2024 2:27 PM > Christophe Lyon wrote: > > > > +/* Disable SEH and declare the required SEH-related macros that are > > > +still needed for compilation. */ #undef TARGET_SEH #define > > > +TARGET_SEH 0 > > > + > > > +#define SSE_REGNO_P(N) 0 > > > +#define GENERAL_REGNO_P(N) 0 > > I think you forgot to add a comment to explain the above two lines. > > (it was requested during v1 review) > > > > Thanks, > > > > Christophe > > Hi Christophe, > > Thank you for the review! > The comment regarding SEH and SEH-related macros has been added two lines > above. > It may not be obvious, but these macros are needed to emit SEH data in > mingw/winnt.cc. > This group is separated by an empty line; however, it still relates to > SEH-related macros. > Thanks for the clarification, I thought that comment only applied to the two lines about TARGET_SEH.
Christophe > Regards, > Evgeny