On Tue, May 07, 2024 at 10:37:55AM +0800, HAO CHEN GUI wrote:
> The former patch adds isfinite optab for __builtin_isfinite.
> https://gcc.gnu.org/pipermail/gcc-patches/2024-April/649339.html
>
> Thus the builtin might not be folded at front end. The range op for
> isfinite is needed for value range analysis. This patch adds them.
>
> Compared to last version, this version fixes a typo.
>
> Bootstrapped and tested on x86 and powerpc64-linux BE and LE with no
> regressions. Is it OK for the trunk?
>
> Thanks
> Gui Haochen
>
> ChangeLog
> Value Range: Add range op for builtin isfinite
>
> The former patch adds optab for builtin isfinite. Thus builtin isfinite might
> not be folded at front end. So the range op for isfinite is needed for value
> range analysis. This patch adds range op for builtin isfinite.
>
> gcc/
> * gimple-range-op.cc (class cfn_isfinite): New.
> (op_cfn_finite): New variables.
> (gimple_range_op_handler::maybe_builtin_call): Handle
> CFN_BUILT_IN_ISFINITE.
>
> gcc/testsuite/
> * gcc/testsuite/gcc.dg/tree-ssa/range-isfinite.c: New test.
BUILT_IN_ISFINITE is just one of many BUILT_IN_IS... builtins,
would be nice to handle the others as well.
E.g. isnormal/isnan/isinf, fpclassify etc.
Note, the man page says for e.g. isnormal that it returns nonzero or zero,
but in reality I think we implement it always inline and can check if
it always returns [0,1].
Some others like isinf return [-1,1] though I think and fpclassify
returns union of all the passed int values.
Jakub
