Hi Duo Zhang,
do you have other concerns regarding the licenses?
Best regards
Alin
On 2022/04/20 13:05:13 "张铎(Duo Zhang)" wrote:
> java -jar apache-rat-0.13.jar ~/nuttx/10.3.0/apps/ > apps_output
>
> Then manually modify the apps_output file to only retain the unapproved
> license file list, and then
>
> awk '{print $1}' < apps_output | awk -F/home/zhangduo/nuttx/10.3.0/ '{print
> $2}' > apps_no_license
>
> grep "\.c$" apps_no_license > apps_no_license_source_files
> grep "\.h$" apps_no_license >> apps_no_license_source_files
> grep "\.S$" apps_no_license >> apps_no_license_source_files
>
> You can get the list with source files which do not have an Apache License.
>
> As most statements in the LICENSE files for NuttX apps are directories, not
> files, let me just post the script I used to filter them out. For
> directory, as my bash skill is not good enough to check diff with prefix, I
> usually do it manually...
>
> grep "^apps/" ~/nuttx/10.3.0/apps/LICENSE
>
> I think after we clean up all these files, we should add them all to the
> ignore list for rat check, and then we could add a rat check step in our ci
> build to confirm that we can find out the license problems.
>
> This is the files without proper license in NuttX apps
> apps/canutils/candump/candump.c
> apps/canutils/cansend/cansend.c
> apps/canutils/libcanutils/lib.c
> apps/examples/canard/canard_main.c
> apps/examples/chat/chat_main.c
> apps/examples/lis3dsh_reader/lis3dsh_reader_main.c
> apps/examples/mlx90614/mlx90614_main.c
> apps/examples/modbusmaster/mbmaster_main.c
> apps/examples/pppd/pppd_main.c
> apps/examples/telnetd/telnetd.c
> apps/examples/webserver/cgi.c
> apps/examples/webserver/webserver_main.c
> apps/examples/xbc_test/xbc_test_main.c
> apps/examples/xmlrpc/calls.c
> apps/examples/xmlrpc/xmlrpc_main.c
> apps/gpsutils/minmea/minmea.c
> apps/interpreters/bas/bas_token.c
> apps/interpreters/ficl/src/nuttx.c
> apps/interpreters/minibasic/basic.c
> apps/interpreters/minibasic/script.c
> apps/modbus/mb.c
> apps/modbus/mb_m.c
> apps/modbus/ascii/mbascii.c
> apps/modbus/functions/mbfunccoils.c
> apps/modbus/functions/mbfunccoils_m.c
> apps/modbus/functions/mbfuncdiag.c
> apps/modbus/functions/mbfuncdisc.c
> apps/modbus/functions/mbfuncdisc_m.c
> apps/modbus/functions/mbfuncholding.c
> apps/modbus/functions/mbfuncholding_m.c
> apps/modbus/functions/mbfuncinput.c
> apps/modbus/functions/mbfuncinput_m.c
> apps/modbus/functions/mbfuncother.c
> apps/modbus/functions/mbutils.c
> apps/modbus/nuttx/portevent.c
> apps/modbus/nuttx/portevent_m.c
> apps/modbus/nuttx/portother.c
> apps/modbus/nuttx/portother_m.c
> apps/modbus/nuttx/portserial.c
> apps/modbus/nuttx/portserial_m.c
> apps/modbus/nuttx/porttimer.c
> apps/modbus/nuttx/porttimer_m.c
> apps/modbus/rtu/mbcrc.c
> apps/modbus/rtu/mbrtu.c
> apps/modbus/rtu/mbrtu_m.c
> apps/modbus/tcp/mbtcp.c
> apps/netutils/chat/chat.c
> apps/netutils/codecs/base64.c
> apps/netutils/codecs/md5.c
> apps/netutils/codecs/urldecode.c
> apps/netutils/dhcpc/dhcpc.c
> apps/netutils/ftpd/ftpd.c
> apps/netutils/netlib/netlib_ethaddrconv.c
> apps/netutils/netlib/netlib_ipv4addrconv.c
> apps/netutils/pppd/ahdlc.c
> apps/netutils/pppd/ipcp.c
> apps/netutils/pppd/lcp.c
> apps/netutils/pppd/pap.c
> apps/netutils/pppd/ppp.c
> apps/netutils/pppd/pppd.c
> apps/netutils/smtp/smtp.c
> apps/netutils/thttpd/fdwatch.c
> apps/netutils/thttpd/libhttpd.c
> apps/netutils/thttpd/tdate_parse.c
> apps/netutils/thttpd/thttpd.c
> apps/netutils/thttpd/thttpd_cgi.c
> apps/netutils/thttpd/thttpd_strings.c
> apps/netutils/thttpd/timers.c
> apps/netutils/thttpd/cgi-src/phf.c
> apps/netutils/thttpd/cgi-src/redirect.c
> apps/netutils/thttpd/cgi-src/ssi.c
> apps/netutils/webclient/webclient.c
> apps/netutils/webserver/httpd.c
> apps/netutils/webserver/httpd_cgi.c
> apps/netutils/webserver/httpd_fs.c
> apps/netutils/xmlrpc/response.c
> apps/netutils/xmlrpc/xmlparser.c
> apps/platform/dummy/dummy.c
> apps/system/cu/cu_main.c
> apps/system/hexed/src/bfile.c
> apps/system/hexed/src/cmdargs.c
> apps/system/hexed/src/hexcopy.c
> apps/system/hexed/src/hexdump.c
> apps/system/hexed/src/hexed.c
> apps/system/hexed/src/hexenter.c
> apps/system/hexed/src/hexhelp.c
> apps/system/hexed/src/hexinsert.c
> apps/system/hexed/src/hexmove.c
> apps/system/hexed/src/hexremove.c
> apps/system/hexed/src/hexword.c
> apps/system/lzf/lzf_main.c
> apps/system/tee/tee.c
> apps/system/telnet/telnet_chatd.c
> apps/system/telnet/telnet_client.c
> apps/system/ubloxmodem/ubloxmodem_main.c
> apps/system/zmodem/host/crc16.c
> apps/system/zmodem/host/crc32.c
> apps/testing/scanftest/scanftest_main.c
> apps/wireless/wapi/src/driver_wext.c
> apps/wireless/wapi/src/network.c
> apps/wireless/wapi/src/util.c
> apps/wireless/wapi/src/wapi.c
> apps/wireless/wapi/src/wireless.c
> apps/canutils/libcanutils/lib.h
> apps/canutils/libcanutils/terminal.h
> apps/examples/webserver/cgi.h
> apps/graphics/nxglyphs/include/cursor-arrow1-16x16.h
> apps/graphics/nxglyphs/include/cursor-arrow1-30x30.h
> apps/graphics/nxglyphs/include/cursor-arrow2-16x16.h
> apps/graphics/nxglyphs/include/cursor-arrow2-30x30.h
> apps/graphics/nxglyphs/include/cursor-grab-14x16.h
> apps/graphics/nxglyphs/include/cursor-grab-25x30.h
> apps/graphics/nxglyphs/include/cursor-resize-16x16.h
> apps/graphics/nxglyphs/include/cursor-resize-30x30.h
> apps/graphics/nxglyphs/include/cursor-resize-61x62.h
> apps/graphics/nxglyphs/include/cursor-wait-13x16.h
> apps/graphics/nxglyphs/include/cursor-wait-23x30.h
> apps/graphics/nxglyphs/include/cursor-zoomin-16x16.h
> apps/graphics/nxglyphs/include/cursor-zoomin-30x30.h
> apps/graphics/nxglyphs/include/cursor-zoomout-16x16.h
> apps/graphics/nxglyphs/include/cursor-zoomout-30x30.h
> apps/graphics/nxwidgets/doc/mainpage.h
> apps/include/gpsutils/minmea.h
> apps/include/interpreters/minibasic.h
> apps/include/modbus/mb.h
> apps/include/modbus/mb_m.h
> apps/include/modbus/mbframe.h
> apps/include/modbus/mbfunc.h
> apps/include/modbus/mbport.h
> apps/include/modbus/mbproto.h
> apps/include/modbus/mbutils.h
> apps/include/netutils/base64.h
> apps/include/netutils/chat.h
> apps/include/netutils/dhcpc.h
> apps/include/netutils/dhcpd.h
> apps/include/netutils/httpd.h
> apps/include/netutils/md5.h
> apps/include/netutils/netlib.h
> apps/include/netutils/pppd.h
> apps/include/netutils/smtp.h
> apps/include/netutils/webclient.h
> apps/include/netutils/xmlrpc.h
> apps/include/wireless/wapi.h
> apps/interpreters/ficl/src/nuttx.h
> apps/modbus/ascii/mbascii.h
> apps/modbus/nuttx/port.h
> apps/modbus/rtu/mbcrc.h
> apps/modbus/rtu/mbrtu.h
> apps/modbus/rtu/mbrtu_m.h
> apps/modbus/tcp/mbtcp.h
> apps/netutils/chat/chat.h
> apps/netutils/pppd/ahdlc.h
> apps/netutils/pppd/ipcp.h
> apps/netutils/pppd/lcp.h
> apps/netutils/pppd/pap.h
> apps/netutils/pppd/ppp.h
> apps/netutils/pppd/ppp_arch.h
> apps/netutils/pppd/ppp_conf.h
> apps/netutils/thttpd/fdwatch.h
> apps/netutils/thttpd/libhttpd.h
> apps/netutils/thttpd/mime_types.h
> apps/netutils/thttpd/tdate_parse.h
> apps/netutils/thttpd/thttpd_alloc.h
> apps/netutils/thttpd/thttpd_cgi.h
> apps/netutils/thttpd/thttpd_strings.h
> apps/netutils/thttpd/timers.h
> apps/netutils/webserver/httpd.h
> apps/netutils/webserver/httpd_cgi.h
> apps/nshlib/nsh_romfsimg.h
> apps/system/cu/cu.h
> apps/system/hexed/include/bfile.h
> apps/system/hexed/include/cmdargs.h
> apps/system/hexed/include/hexed.h
> apps/system/ubloxmodem/ubloxmodem.h
> apps/wireless/wapi/src/util.h
>
> This is the list which we have already listed in the LICENSE file
> apps/netutils/pppd
> apps/testing/scanftest/scanftest_main.c
> apps/webserver
> apps/examples/lvgldemo
> apps/interpreters/bas
> apps/canutils/candump
> apps/canutils/cansend
> apps/canutils/libcanutils
> apps/wireless/wapi
> apps/system/cu
> apps/system/hexed
> apps/examples/lzf
> apps/gpsutils/minmea/minmea.c
> apps/examples/canard
> apps/examples/chat
> apps/examples/json
> apps/examples/lis3dsh_reader
> apps/examples/mlx90614
> apps/examples/modbusmaster
> apps/examples/telnetd
> apps/examples/webserver
> apps/examples/xbc_test
> apps/examples/xmlrpc
> apps/netutils/codecs
> apps/netutils/dhcpc/dhcpc.c
> apps/netutils/ftpd/ftpd.c
> apps/netutils/netlib
> apps/netutils/dhcpc
> apps/netutitls/smtp
> apps/netutils/webclient
> apps/netutils/thttpd
>
> 张铎(Duo Zhang) <palomino...@gmail.com> 于2022年4月20日周三 16:10写道：
>
> > Sorry, a bit busy yesterday...
> > Will do it when I find some spare time...
> >
> > Alin Jerpelea <jerpe...@apache.org> 于2022年4月20日周三 14:49写道：
> >
> >> HI Duo Zhang
> >>
> >> did you manage to generate the list for apps?
> >>
> >> Thanks
> >> Alin
> >>
> >>
> >> On 2022/04/19 09:32:43 "张铎(Duo Zhang)" wrote:
> >> > No problem. Will do this tonight and also post the scripts I used to
> >> > generate the list.
> >> >
> >> > Alin Jerpelea <jerpe...@apache.org> 于2022年4月19日周二 16:01写道：
> >> >
> >> > > can you please share the list for apps
> >> > >
> >> > > Thanks
> >> > > Alin
> >> > >
> >> > >
> >> > > On 2022/04/19 05:51:32 "张铎(Duo Zhang)" wrote:
> >> > > > I suggest we analyze these files first, if we should add them to the
> >> > > > LICENSE files too, we should cancel this vote.
> >> > > >
> >> > > > Do not worry, this is our first release without a DISCLAIMER. If we
> >> could
> >> > > > finally publish this release, it is a direct sign that NuttX could
> >> > > graduate
> >> > > > as a TLP :)
> >> > > >
> >> > > > Nathan Hartman <hartman.nat...@gmail.com> 于2022年4月19日周二 02:03写道：
> >> > > >
> >> > > > > On Thu, Apr 14, 2022 at 10:39 AM 张铎(Duo Zhang) <
> >> palomino...@gmail.com>
> >> > > > > wrote:
> >> > > > > >
> >> > > > > > Ah, then let me just post them as the content. I've removed
> >> several
> >> > > files
> >> > > > > > from the list by the information you provided. And I suggested
> >> that
> >> > > when
> >> > > > > > you specify a library, better also provide the place where the
> >> > > related
> >> > > > > > files are stored. For example, The Rhombus math library, I do
> >> not
> >> > > know
> >> > > > > > which files are for it...
> >> > > > > >
> >> > > > > > This is the remaining files. PTAL.
> >> > > > > >
> >> > > > > > arch/arm/src/am335x/am335x_lcdc.c
> >> > > > > > arch/arm/src/armv7-a/cp15_clean_dcache_all.S
> >> > > > > > arch/arm/src/armv7-a/cp15_flush_dcache_all.S
> >> > > > > > arch/arm/src/armv7-r/cp15_clean_dcache_all.S
> >> > > > > > arch/arm/src/armv7-r/cp15_flush_dcache_all.S
> >> > > > > > arch/arm/src/cxd56xx/hardware/cxd5602_isop.h
> >> > > > > > arch/arm/src/cxd56xx/hardware/cxd5602_isop_hadc0_highspeed.h
> >> > > > > > arch/arm/src/imxrt/hardware/rt102x/imxrt102x_xbar.h
> >> > > > > > arch/arm/src/imxrt/hardware/rt105x/imxrt105x_xbar.h
> >> > > > > > arch/arm/src/imxrt/hardware/rt106x/imxrt106x_xbar.h
> >> > > > > > arch/arm/src/lpc2378/lpc23xx_head.S
> >> > > > > > arch/arm/src/lpc43xx/lpc43_emc.c
> >> > > > > > arch/arm/src/lpc43xx/lpc43_rtc.h
> >> > > > > > arch/arm/src/phy62xx/phy62xx_exception.S
> >> > > > > > arch/arm/src/phy62xx/phy62xx_start.S
> >> > > > > > arch/arm/src/samd2l2/sam_i2c_master.c
> >> > > > > > arch/arm/src/samd5e5/sam_i2c_master.c
> >> > > > > > arch/arm/src/stm32l4/stm32l4_fsmc.h
> >> > > > > > arch/arm/src/stm32l4/stm32l4_lcd.h
> >> > > > > > arch/arm/src/tiva/common/tiva_pwm.c
> >> > > > > > arch/arm/src/tiva/common/tiva_qencoder.c
> >> > > > > > arch/arm/src/tiva/hardware/lm/lm3s_timer.h
> >> > > > > > arch/arm/src/tiva/hardware/lm/lm4f_timer.h
> >> > > > > > arch/arm/src/tiva/hardware/tiva_adc.h
> >> > > > > > arch/arm/src/tiva/hardware/tiva_epi.h
> >> > > > > > arch/arm/src/tiva/hardware/tiva_pwm.h
> >> > > > > > arch/arm/src/tiva/hardware/tiva_qencoder.h
> >> > > > > > arch/arm/src/tiva/hardware/tm4c/tm4c123_timer.h
> >> > > > > > arch/arm/src/tiva/hardware/tm4c/tm4c129_timer.h
> >> > > > > > arch/arm/src/tiva/hardware/tm4c/tm4c_ethernet.h
> >> > > > > > arch/arm/src/tiva/hardware/tm4c/tm4c_flash.h
> >> > > > > > arch/arm/src/tiva/tiva_adc.h
> >> > > > > > arch/arm/src/tiva/tiva_pwm.h
> >> > > > > > arch/arm/src/tiva/tiva_qencoder.h
> >> > > > > > arch/or1k/src/mor1kx/hardware/irq.h
> >> > > > > > arch/xtensa/src/common/xtensa_asm_utils.h
> >> > > > > > boards/arm/sama5/sama5d4-ek/include/nsh_romfsimg.h
> >> > > > > > boards/arm/stm32/emw3162/src/stm32_wlan_firmware.c
> >> > > > > > boards/arm/stm32l4/stm32l476vg-disco/include/nsh_romfsimg.h
> >> > > > > > boards/arm/stm32l4/stm32l4r9ai-disco/include/nsh_romfsimg.h
> >> > > > > > boards/sim/sim/sim/include/board.h
> >> > > > > > boards/sim/sim/sim/src/dummy.c
> >> > > > > > drivers/leds/ncp5623c.c
> >> > > > > > drivers/mtd/at24xx.c
> >> > > > > > drivers/mtd/gd5f.c
> >> > > > > > drivers/sensors/mlx90614.c
> >> > > > > > drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio_core.h
> >> > > > > > drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio_regs.h
> >> > > > > > include/nuttx/fs/nfs.h
> >> > > > > > include/nuttx/himem/himem.h
> >> > > > > > include/nuttx/leds/ncp5623c.h
> >> > > > > > include/nuttx/net/arp.h
> >> > > > > > include/nuttx/net/can.h
> >> > > > > > include/nuttx/net/dns.h
> >> > > > > > include/nuttx/net/ethernet.h
> >> > > > > > include/nuttx/net/icmp.h
> >> > > > > > include/nuttx/net/icmpv6.h
> >> > > > > > include/nuttx/net/igmp.h
> >> > > > > > include/nuttx/net/ip.h
> >> > > > > > include/nuttx/net/netconfig.h
> >> > > > > > include/nuttx/net/netdev.h
> >> > > > > > include/nuttx/net/netstats.h
> >> > > > > > include/nuttx/net/sixlowpan.h
> >> > > > > > include/nuttx/net/tcp.h
> >> > > > > > include/nuttx/net/tun.h
> >> > > > > > include/nuttx/net/udp.h
> >> > > > > > include/nuttx/wireless/bluetooth/bt_buf.h
> >> > > > > > include/nuttx/wireless/bluetooth/bt_core.h
> >> > > > > > include/nuttx/wireless/bluetooth/bt_driver.h
> >> > > > > > include/nuttx/wireless/bluetooth/bt_gatt.h
> >> > > > > > include/nuttx/wireless/bluetooth/bt_hci.h
> >> > > > > > include/nuttx/wireless/bluetooth/bt_ioctl.h
> >> > > > > > include/nuttx/wireless/bluetooth/bt_null.h
> >> > > > > > include/nuttx/wireless/bluetooth/bt_uart.h
> >> > > > > > include/nuttx/wireless/bluetooth/bt_uuid.h
> >> > > > > > include/nuttx/wireless/ieee80211/ieee80211_cypto.h
> >> > > > > > include/nuttx/wireless/ieee80211/ieee80211.h
> >> > > > > > libs/libc/machine/arm/armv7-a/gnu/arch_memcpy.S
> >> > > > > > libs/libc/machine/arm/armv7-m/gnu/arch_memcpy.S
> >> > > > > > libs/libc/machine/arm/armv7-r/gnu/arch_memcpy.S
> >> > > > > > libs/libc/misc/lib_crc16.c
> >> > > > > > libs/libc/misc/lib_crc32.c
> >> > > > > > libs/libc/misc/lib_fnmatch.c
> >> > > > > > libs/libc/misc/lib_ncompress.c
> >> > > > > > libs/libc/misc/lib_utsname.c
> >> > > > > > libs/libc/netdb/lib_dns.h
> >> > > > > > libs/libc/netdb/lib_dnsquery.c
> >> > > > > > libs/libc/net/lib_addrconfig.c
> >> > > > > > libs/libc/stdlib/lib_strtod.c
> >> > > > > > libs/libc/stdlib/lib_strtof.c
> >> > > > > > libs/libc/stdlib/lib_strtold.c
> >> > > > > > libs/libc/stdlib/lib_wctomb.c
> >> > > > > > libs/libc/string/lib_vikmemcpy.c
> >> > > > > > net/arp/arp_arpin.c
> >> > > > > > net/arp/arp_dump.c
> >> > > > > > net/arp/arp_format.c
> >> > > > > > net/arp/arp_ipin.c
> >> > > > > > net/arp/arp_out.c
> >> > > > > > net/arp/arp_table.c
> >> > > > > > net/devif/devif.h
> >> > > > > > net/devif/devif_initialize.c
> >> > > > > > net/devif/devif_send.c
> >> > > > > > net/devif/ipv4_input.c
> >> > > > > > net/icmp/icmp_input.c
> >> > > > > > net/igmp/igmp_group.c
> >> > > > > > net/igmp/igmp_initialize.c
> >> > > > > > net/igmp/igmp_input.c
> >> > > > > > net/igmp/igmp_join.c
> >> > > > > > net/igmp/igmp_leave.c
> >> > > > > > net/igmp/igmp_mcastmac.c
> >> > > > > > net/igmp/igmp_msg.c
> >> > > > > > net/igmp/igmp_poll.c
> >> > > > > > net/igmp/igmp_timer.c
> >> > > > > > net/sixlowpan/sixlowpan_framelist.c
> >> > > > > > net/sixlowpan/sixlowpan_hc06.c
> >> > > > > > net/sixlowpan/sixlowpan_hc1.c
> >> > > > > > net/sixlowpan/sixlowpan_input.c
> >> > > > > > net/sixlowpan/sixlowpan_internal.h
> >> > > > > > net/sixlowpan/sixlowpan_utils.c
> >> > > > > > net/tcp/tcp_appsend.c
> >> > > > > > net/tcp/tcp_conn.c
> >> > > > > > net/tcp/tcp_devpoll.c
> >> > > > > > net/tcp/tcp_input.c
> >> > > > > > net/tcp/tcp_listen.c
> >> > > > > > net/tcp/tcp_send.c
> >> > > > > > net/tcp/tcp_seqno.c
> >> > > > > > net/tcp/tcp_timer.c
> >> > > > > > net/udp/udp_conn.c
> >> > > > > > net/udp/udp_devpoll.c
> >> > > > > > net/udp/udp_input.c
> >> > > > > > net/udp/udp_send.c
> >> > > > >
> >> > > > >
> >> > > > > I am wondering, should we withdraw the vote and clear the above
> >> > > licenses?
> >> > > > >
> >> > > > > Cheers,
> >> > > > > Nathan
> >> > > > >
> >> > > >
> >> > >
> >> > > ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >> > > For additional commands, e-mail: general-h...@incubator.apache.org
> >> > >
> >> > >
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >> For additional commands, e-mail: general-h...@incubator.apache.org
> >>
> >>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
