+1 (binding) from me, I have checked the following items: - Incubating in name - LICENSE and NOTICE are fine - DISCLAIMER-WIP exists - All links are valid - No unexpected binary files - All ASF files have ASF headers - Can compile from source `mvn clean install`
Best regards Xun Liu On 2023/12/06 09:34:21 Liang Chen wrote: > +1(binding) > > Regards > Liang > > 张铎(Duo Zhang) <palomino...@gmail.com> 于 2023年12月3日周日 09:07写道： > > > +1 binding > > > > Checked sigs and sums: Matched > > LICENSE and NOTICE: In place > > DISCLAIMER-WIP: > > In place, and I saw PJ Fanning has already sent an email to > > dev@pegasus for changing to use the standard DISCLAIMER, thanks for > > taking care of this > > Built from src: > > Successfully build the packages following the steps here > > https://pegasus.apache.org/docs/build/compile-by-docker/ > > Run tests: > > First there is no documentation on how to test the project, and > > there is already a PR for improving the documentation > > https://github.com/apache/incubator-pegasus-website/pull/33 > > Second, I tried several times but still can not get all the tests > > pass, and the framework will fail with segmentation fault so there is > > no conclusion so it is really hard for me to find out the failed tests > > locally. Although we have ci support on github for running thest > > tests, we still need to polish the test framework as when verifying a > > release, we still need to run these tests locally. > > Third, we still need to download things from > > https://github.com/XiaoMi/pegasus-common when running tests, it should > > be some faked testing data. We need to remove this dependency, either > > we let xiaomi donate this repo too, or we need to make some fake data > > by our own and upload it to other places, like nightlies.a.o. > > Anyway, these are not blockers for a release, but are all blockers > > for graduation... Let's improve soon... > > > > BTW, lots of the pages on pegasus.a.o are still under translating, I > > think we should improve this too. > > > > Thanks. > > > > Dan Wang <wang...@apache.org> 于2023年12月1日周五 18:12写道： > > > > > > > > Hi PJ, > > > > > > Sorry for the broken links. I've fixed both, please try again: > > > > > https://cwiki.apache.org/confluence/display/PEGASUS/Validating+a+staged+release > > > > > > > > > On Fri, Dec 1, 2023 at 5:41 PM PJ Fanning <fannin...@apache.org> wrote: > > > > > > > Both links under `Compile Pegasus` section are broken. The 2nd one is > > > > a localhost link. > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/PEGASUS/Validating+a+staged+release > > > > > > > > On Fri, 1 Dec 2023 at 09:00, Dan Wang <wang...@apache.org> wrote: > > > > > > > > > > Hello all, > > > > > > > > > > This is a call for a vote to release Apache Pegasus (Incubating) > > version > > > > > 2.5.0. > > > > > > > > > > The Apache Pegasus community has voted on and approved a proposal to > > > > > release Apache Pegasus (Incubating) version 2.5.0. > > > > > > > > > > We now kindly request the Incubator PMC members review and vote on > > > > > this incubator release. > > > > > > > > > > Apache Pegasus is a distributed key-value storage system that is > > designed > > > > > to be simple, horizontally scalable, strongly consistent, and > > > > > high-performance. > > > > > > > > > > Apache Pegasus community vote and result thread: > > > > > Vote: > > https://lists.apache.org/thread/ob0h55oq9yr0d77czprftw24wwx2xchr > > > > > Result: > > https://lists.apache.org/thread/p54269djfbwgllwp7trj0c12x07w4xp8 > > > > > > > > > > The source tarball, including signatures, digests, etc. can be found > > at: > > > > > https://dist.apache.org/repos/dist/dev/incubator/pegasus/2.5.0-RC1/ > > > > > > > > > > It is tagged in Git as v2.5.0-RC1 on Github: > > > > > https://github.com/apache/incubator-pegasus/tree/v2.5.0-RC1 > > > > > > > > > > The corresponding hash is the following: > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=incubator-pegasus.git;a=commit;h=0ca31b70eac7321bb17fb034105695597245d47b > > > > > > > > > > For information about the contents of this release, see release > > notes: > > > > > > > > > > > https://github.com/apache/incubator-pegasus/blob/50563ea33b33c5ae1a6d9b8e4cf74a7d1d9133b0/HISTORY.md > > > > > > > > > > The artifacts have been signed with Key : 8041A06E53E4312A, which can > > > > > be found in KEYS file: > > > > > https://downloads.apache.org/incubator/pegasus/KEYS > > > > > > > > > > Look at here for how to verify this release candidate: > > > > > > > > > > > https://cwiki.apache.org/confluence/display/PEGASUS/Validating+a+staged+release > > > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > number > > > > > of votes are reached. > > > > > > > > > > Please vote accordingly: > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > > > > Best regards, > > > > > Dan Wang > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
