On 05/16/2014 03:35 PM, Johan Tibell wrote: > On Fri, May 16, 2014 at 3:33 PM, Mateusz Kowalczyk > <fuuze...@fuuzetsu.co.uk>wrote: > >> Is there a reason behind not just detabbing (and removing trailing >> whitespace) the whole tree in a patch? If you're going to detab in a >> separate patch anyway, might as well do all of it once and for all. > > > There are two reasons: > > * Main reason: it will create lots of merge conflicts for people working > on the code base.
I suppose such action would be announced a week or so beforehand but yes, I suppose. > * Minor reason: you will now be 'git blame'd for most lines of the source. > It's possible to have git ignore that, but it's a source of annoyance. It does not matter I feel because you're encouraged to detab in a separate patch anyway so blaming will show that whether it's all done at once or separately. -- Mateusz K. _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs