I think reverting the patch (and notifying the author) is an OK course of action if it's affecting other people's work. I believe it's common practice at many other places. The patch can always be replied later, after fixing it.
P.S. We should re-open the bug if we revert the patch (i.e. by git revert SHA1 && git push). On Fri, Aug 22, 2014 at 2:07 PM, Simon Peyton Jones <simo...@microsoft.com> wrote: > Friends > > My Windows build is still broken, and has been since Andreas's patch > commit f9f89b7884ccc8ee5047cf4fffdf2b36df6832df > on Tues 19th. > > Please can someone help? I'm begging. > > I suppose that if I hear nothing I can simply revert his patch but that > seems like the Wrong Solution > > Thanks > > Simon > > | -----Original Message----- > | From: Simon Peyton Jones > | Sent: 20 August 2014 23:48 > | To: 'Gabor Greif'; 'ghc-devs@haskell.org'; 'Andreas Voellmy' > | Subject: RE: Windows build fails -- again! > | > | Help! My Windows build is still falling over as below. > | > | Andreas, you seem to be the author of the commit that broke this. I'd > | really appreciate a fix. (From anyone!) > | > | thank you > | > | Simon > | > | | -----Original Message----- > | | From: Simon Peyton Jones > | | Sent: 20 August 2014 09:26 > | | To: Gabor Greif; ghc-devs@haskell.org > | | Subject: RE: Windows build fails -- again! > | | > | | Thanks Gabor. But it makes no difference. Your change is inside an > | | #ifdef that checks for windows, and your change is in the no-windows > | | branch only. > | | > | | Also there are two IOManager.h file > | | includes/rts/IOManager.h > | | rts/win32/IOManager.h > | | > | | Should there be? It seems terribly confusing, and I have no idea which > | | will win when it is #included. > | | > | | Thanks > | | > | | Simon > | | > | | | -----Original Message----- > | | | From: Gabor Greif [mailto:ggr...@gmail.com] > | | | Sent: 19 August 2014 23:38 > | | | To: Simon Peyton Jones > | | | Subject: Re: Windows build fails -- again! > | | | > | | | Simon, > | | | > | | | try this (attached) patch: > | | | > | | | $ git am 0001-Make-sure-that-a-prototype-is-included-for- > | | | setIOMana.patch > | | | > | | | Cheers, > | | | > | | | Gabor > | | | > | | | PS: on MacOS all is good, so I could not test it at all > | | | > | | | On 8/20/14, Simon Peyton Jones <simo...@microsoft.com> wrote: > | | | > Aaargh! My windows build is broken, again. > | | | > It's very painful that this keeps happening. > | | | > Can anyone help? > | | | > Simon > | | | > > | | | > "inplace/bin/ghc-stage1.exe" -optc-U__i686 -optc-march=i686 > | | | > -optc-fno-stack-protector -optc-Werror -optc-Wall -optc-Wall > | | | > -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes > | | | > -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return > | | | > -optc-Wpointer-arith -optc-Wmissing-noreturn -optc-Wnested-externs > | | | > -optc-Wredundant-decls -optc-Iincludes -optc-Iincludes/dist > | | | > -optc-Iincludes/dist-derivedconstants/header > | | | > -optc-Iincludes/dist-ghcconstants/header -optc-Irts > | | | > -optc-Irts/dist/build -optc-DCOMPILING_RTS -optc-fno-strict- > | aliasing > | | | > -optc-fno-common -optc-O2 -optc-fomit-frame-pointer > | | | > -optc-DRtsWay=\"rts_v\" -static -H32m -O -Werror -Wall -H64m -O0 > | | | > -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header > | | | > -Iincludes/dist-ghcconstants/header > | | | > -Irts -Irts/dist/build -DCOMPILING_RTS -this-package-key rts > | | | > -dcmm-lint -i -irts -irts/dist/build -irts/dist/build/autogen - > | | | Irts/dist/build > | | | > -Irts/dist/build/autogen -O2 -c rts/Task.c -o > | | | > rts/dist/build/Task.o > | | | > > | | | > cc1.exe: warnings being treated as errors > | | | > > | | | > > | | | > > | | | > rts\Capability.c:1080:6: > | | | > > | | | > error: no previous prototype for 'setIOManagerControlFd' > | | | > > | | | > rts/ghc.mk:236: recipe for target 'rts/dist/build/Capability.o' > | | | failed > | | | > > | | | > make[1]: *** [rts/dist/build/Capability.o] Error 1 > | | | > > | | | > make[1]: *** Waiting for unfinished jobs.... > | | | > > | | | > Makefile:71: recipe for target 'all' failed > | | | > > | | | > make: *** [all] Error 2 > | | | > > | | | > HEAD (master)$ > | | | > > | | | > > | | | > > _______________________________________________ > ghc-devs mailing list > ghc-devs@haskell.org > http://www.haskell.org/mailman/listinfo/ghc-devs >
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs