Perhaps I'm just stupid, and should be disqualified from using such features. Only as a result of this thread (not from the User Guide nor from the paper) do I discover "use" means match-on.
You are not stupid. And since you misunderstood despite effort, the presentation is - by definition - not as good as it should be. The paper focuses pretty much entirely on matching, and takes building for granted. But I can now see that it is not explicit on this point, and that leaves it open to misinterpretation. I think the paper is reasonably careful to say "match on" rather than "use", but I wouldn't bet on it. I suggest the User Guide needs an example where a constraint needed for matching (presumably via a View pattern) is not amongst the constraints carried inside the data constructor, nor amongst those needed for building. Then the limitations in the current design would be more apparent for users. The user manual<https://ghc.gitlab.haskell.org/ghc/doc/users_guide/exts/pattern_synonyms.html?highlight=pattern%20syn#typing-of-pattern-synonyms> does already speak about the type of a builder, here: * For a bidirectional pattern synonym, a use of the pattern synonym as an expression has the type (CReq, CProv) => t1 -> t2 -> ... -> tN -> t So in the previous example, when used in an expression, ExNumPat has type ExNumPat :: (Num a, Eq a, Show b) => b -> T t Notice that this is a tiny bit more restrictive than the expression MkT 42 x which would not require (Eq a). That does seem to directly address the use of a pattern synonym in an expression, and means that both CReq and Cprov are required at use sites in expressions. It even includes an example of the sort you wanted. How could we make that clearer? Thanks Simon PS: I am leaving Microsoft at the end of November 2021, at which point simo...@microsoft.com<mailto:simo...@microsoft.com> will cease to work. Use simon.peytonjo...@gmail.com<mailto:simon.peytonjo...@gmail.com> instead. (For now, it just forwards to simo...@microsoft.com.) From: Glasgow-haskell-users <glasgow-haskell-users-boun...@haskell.org> On Behalf Of Anthony Clayden Sent: 06 October 2021 06:25 To: Gergő Érdi <ge...@erdi.hu> Cc: GHC users <glasgow-haskell-users@haskell.org> Subject: Re: Pattern synonym constraints :: Ord a => () => ... Thanks Gergö, I've read that paper many times (and the User Guide). Nowhere does it make the distinction between required-for-building vs required-for-matching. And since most of the syntax for PatSyns (the `where` equations) is taken up with building, I'd taken it that "required" means required-for-building. There is one paragraph towards the end of section 6 that kinda hints at the issue here. It's so cryptic it's no help. "An alternative would be to carry two types for each pattern synonym: ...". But already PatSyns carry two sets of _constraints_. The matrix type after the constraints is determined by the mapping to/from the data constructor. Why would there be two of those? What this paragraph might mean (?) is 'carry three sets of constraints', but put one set in a completely different signature. As per the proposal. > they [Required constraints] are "required" to be able to use the pattern > synonym. Is highly misleading. Only as a result of this thread (not from the User Guide nor from the paper) do I discover "use" means match-on. The paper really does not address typing for "use" for building. I agree with SPJ's comment (quoted in the proposal) "This turns out to be wrong in both directions." I suggest the User Guide needs an example where a constraint needed for matching (presumably via a View pattern) is not amongst the constraints carried inside the data constructor, nor amongst those needed for building. Then the limitations in the current design would be more apparent for users. Perhaps I'm just stupid, and should be disqualified from using such features. (I keep away from GADTs for those reasons.) So I'm not going to volunteer to revise the User Guide further. On Wed, 6 Oct 2021 at 15:26, Gergő Érdi <ge...@erdi.hu<mailto:ge...@erdi.hu>> wrote: If you haven't yet, it is probably a good idea to read section 6 of https://gergo.erdi.hu/papers/patsyns/2016-hs-patsyns-ext.pdf<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgergo.erdi.hu%2Fpapers%2Fpatsyns%2F2016-hs-patsyns-ext.pdf&data=04%7C01%7Csimonpj%40microsoft.com%7Cf208f3e0240646a9829f08d98889d751%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637690948080937568%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=YhqSQ%2BWSfz5Ycmt8aynh9jJaUVNiiK3kkPrLj1pILx4%3D&reserved=0> On Wed, Oct 6, 2021 at 10:23 AM Gergő Érdi <ge...@erdi.hu<mailto:ge...@erdi.hu>> wrote: > > > I'm afraid none of this is apparent from the User Guide -- and I even > > contributed some material to the Guide, without ever understanding that. > > Before this thread, I took it that 'Required' means for building -- as in > > for smart constructors. > > No, that's not what the required/provided distinction means at all! > > You should think of both Provided and Required in the context of > matching, not in the context of building. To be able to use a pattern > synonym to match on a scrutinee of type T, not only does T have to > match the scrutinee type of the pattern synonym, but you also must > satisfy the constraints of the Required constraints -- they are > "required" to be able to use the pattern synonym. On the flipside, > once you do use the pattern synonym, on the right-hand side of your > matched clause you now get to assume the Provided constraints -- in > other words, those constraints are "provided" to you by the pattern > synonym. > > It is true that the builder could have entirely unrelated constraints > to either (as in the proposal). The current implementation basically > assumes that the Provided constraints can be provided because the > builder put them in. > > Does this make it clearer? > > On Wed, Oct 6, 2021 at 10:13 AM Anthony Clayden > <anthony.d.clay...@gmail.com<mailto:anthony.d.clay...@gmail.com>> wrote: > > > > > > Thank you. Yes that proposal seems in 'the same ball park'. As Richard's > > already noted, a H98 data constructor can't _Provide_ any constraints, > > because it has no dictionaries wrapped up inside. But I'm not asking it to! > > > > The current PatSyn signatures don't distinguish between > > Required-for-building vs Required-for-matching (i.e. > > deconstructing/reformatting to the PatSyn). This seems no better than > > 'stupid theta': I'm not asking for any reformatting to pattern-match, just > > give me the darn components, they are what they are where they are. > > > > I'm afraid none of this is apparent from the User Guide -- and I even > > contributed some material to the Guide, without ever understanding that. > > Before this thread, I took it that 'Required' means for building -- as in > > for smart constructors. So PatSyns aren't really aimed to be for smart > > constructors? I should take that material out of the User Guide? > > > > > > AntC > > > > > > On Wed, 6 Oct 2021 at 10:53, Richard Eisenberg > > <li...@richarde.dev<mailto:li...@richarde.dev>> wrote: > >> > >> You're right -- my apologies. Here is the accepted proposal: > >> https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0042-bidir-constr-sigs.rst<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fblob%2Fmaster%2Fproposals%2F0042-bidir-constr-sigs.rst&data=04%7C01%7Csimonpj%40microsoft.com%7Cf208f3e0240646a9829f08d98889d751%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637690948080947564%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=Cdf7aEeHc8yXFJCn8aX9WdGGJueQsqGK0zY7Ib%2B6FsY%3D&reserved=0> > >> > >> Richard > >> > >> On Oct 5, 2021, at 12:38 PM, David Feuer > >> <david.fe...@gmail.com<mailto:david.fe...@gmail.com>> wrote: > >> > >> To be clear, the proposal to allow different constraints was accepted, but > >> integrating it into the current, incredibly complex, code was well beyond > >> the limited abilities of the one person who made an attempt. Totally > >> severing pattern synonyms from constructor synonyms (giving them separate > >> namespaces) would be a much simpler design. > >> > >> On Tue, Oct 5, 2021, 12:33 PM Richard Eisenberg > >> <li...@richarde.dev<mailto:li...@richarde.dev>> wrote: > >>> > >>> > >>> > >>> On Oct 3, 2021, at 5:38 AM, Anthony Clayden > >>> <anthony.d.clay...@gmail.com<mailto:anthony.d.clay...@gmail.com>> wrote: > >>> > >>> > pattern SmartConstr :: Ord a => () => ... > >>> > >>> Seems to mean: > >>> > >>> * Required constraint is Ord a -- fine, for building > >>> > >>> > >>> Yes. > >>> > >>> * Provided constraint is Ord a -- why? for matching/consuming > >>> > >>> > >>> No. Your signature specified that there are no provided constraints: > >>> that's your (). > >>> > >>> > >>> I'm using `SmartConstr` with some logic inside it to validate/build a > >>> well-behaved data structure. But this is an ordinary H98 datatype, not a > >>> GADT. > >>> > >>> > >>> I believe there is no way to have provided constraints in Haskell98. You > >>> would need either GADTs or higher-rank types. > >>> > >>> > >>> This feels a lot like one of the things that's wrong with 'stupid theta' > >>> datatype contexts. > >>> > >>> > >>> You're onto something here. Required constraints are very much like the > >>> stupid theta datatype contexts. But, unlike the stupid thetas, required > >>> constraints are sometimes useful: they might be needed in order to, say, > >>> call a function in a view pattern. > >>> > >>> For example: > >>> > >>> checkLT5AndReturn :: (Ord a, Num a) => a -> (Bool, a) > >>> checkLT5AndReturn x = (x < 5, x) > >>> > >>> pattern LessThan5 :: (Ord a, Num a) => a -> a > >>> pattern LessThan5 x <- ( checkLT5AndReturn -> (True, x) ) > >>> > >>> > >>> My view pattern requires (Ord a, Num a), and so I must declare these as > >>> required constraints in the pattern synonym type. Because vanilla data > >>> constructors never do computation, any required constraints for data > >>> constructors are always useless. > >>> > >>> > >>> For definiteness, the use case is a underlying non-GADT constructor for a > >>> BST > >>> > >>> > Node :: Tree a -> a -> Tree a -> Tree a > >>> > > >>> > pattern SmartNode :: Ord a => () => Tree a -> a -> Tree a -> Tree a > >>> > >>> with the usual semantics that the left Tree holds elements less than this > >>> node. Note it's the same `a` with the same `Ord a` 'all the way down' the > >>> Tree. > >>> > >>> > >>> Does SmartNode need Ord a to match? Or just to produce a node? It seems > >>> that Ord a is used only for production, not for matching. This suggests > >>> that you want a separate smartNode function (not a pattern synonym) and > >>> to have no constraints on the pattern synonym, which can be > >>> unidirectional (that is, work only as a pattern, not as an expression). > >>> > >>> It has been mooted to allow pattern synonyms to have two types: one when > >>> used as a pattern and a different one when used as an expression. That > >>> might work for you here: you want SmartNode to have no constraints as a > >>> pattern, but an Ord a constraint as an expression. At the time, the > >>> design with two types was considered too complicated and abandoned. > >>> > >>> Does this help? > >>> > >>> Richard > >>> _______________________________________________ > >>> Glasgow-haskell-users mailing list > >>> Glasgow-haskell-users@haskell.org<mailto:Glasgow-haskell-users@haskell.org> > >>> http://mail.haskell.org/cgi-bin/mailman/listinfo/glasgow-haskell-users<https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fglasgow-haskell-users&data=04%7C01%7Csimonpj%40microsoft.com%7Cf208f3e0240646a9829f08d98889d751%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637690948080957559%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=z1wP8QMlfRhfNmbX0n0HuoYx6MufLQdMjCTgBVZMqcs%3D&reserved=0> > >> > >> > > _______________________________________________ > > Glasgow-haskell-users mailing list > > Glasgow-haskell-users@haskell.org<mailto:Glasgow-haskell-users@haskell.org> > > http://mail.haskell.org/cgi-bin/mailman/listinfo/glasgow-haskell-users<https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fglasgow-haskell-users&data=04%7C01%7Csimonpj%40microsoft.com%7Cf208f3e0240646a9829f08d98889d751%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637690948080967559%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=dw%2BRrhD1RqrZYMSCjXNRofuuC6PHtgRjVd%2BmlBQQkoI%3D&reserved=0>
_______________________________________________ Glasgow-haskell-users mailing list Glasgow-haskell-users@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/glasgow-haskell-users
