On 07/07/2014 03:11 PM, Justin Clift wrote:
On 07/07/2014, at 2:50 AM, Pranith Kumar Karampuri wrote:
On 07/06/2014 11:05 PM, Vijay Bellur wrote:
On 07/06/2014 07:47 PM, Pranith Kumar Karampuri wrote:
hi Justin/Vijay,
I always felt '-1' saying 'I prefer you didn't submit this' is a
bit harsh. Most of the times all it means is 'Need some more changes' Do
you think we can change this message?
The message can be changed. What would everyone like to see as appropriate
messages accompanying values '-1' and '-2'?
For '-1' - 'Please address the comments and Resubmit.'
That sounds good. :)
I am not sure about '-2'
Maybe something like?
"I have strong doubts about this approach"
(seems to reflect it's usage)
Agree :-)
Pranith
+ Justin
--
GlusterFS - http://www.gluster.org
An open source, distributed file system scaling to several
petabytes, and handling thousands of clients.
My personal twitter: twitter.com/realjustinclift
_______________________________________________
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel
