https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #9 from Amar Tumballi <atumb...@redhat.com> --- (In reply to Nigel Babu from comment #7) > Alright. So we have agreement that this is a good idea. How do we want to > implement this? As a check or as a pre-commit hook? This is a multi-step process! 0. Team agrees on a style and a config file representing the style. 1. Commit the coding style guide to codebase and make changes in rfc.sh to use it. 2. 'gluster-ant' commits a single large patch for whole codebase with a standard clang-format style. (This should be only changes which happened due to clang-format, and no other changes should be in the patch. This can crash gerrit if we send it to review. -> NOTE: This change can be as big as moving gluster repo from tla to git, as we have now 2 repositories, 'historic' and 'glusterfs' to understand the actual source of a line, if one needs 'git blame'. 3. Have the job ready to check the patch with the config file, on the server side (along with a pre-check in rfc.sh to warn people), this should be a Voting job in smoke. 4. We all live happily ever after. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rNXvC1NMQK&a=cc_unsubscribe _______________________________________________ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
