On Wed, 18 Sep 2013 11:56:37 +0200 Geert Janssens <janssens-ge...@telenet.be> wrote:
> On Wednesday 18 September 2013 05:40:45 Mike Evans wrote: > > Author: mikee > > Date: 2013-09-18 05:40:44 -0400 (Wed, 18 Sep 2013) > > New Revision: 23175 > > Trac: http://svn.gnucash.org/trac/changeset/23175 > > > > Modified: > > gnucash/trunk/src/gnome/gnc-budget-view.c > > Log: > > Fix bug 699450 > > > > * Remove extra call to gtk_tree_view_append_column. (It is already > > called in gnc_tree_view_account_add_custom_column.) > > > > Author: Robert Ratliff <ratliff.bo...@gmail.com> > > > > Modified: gnucash/trunk/src/gnome/gnc-budget-view.c > > > ========================================================== > ========= > > --- gnucash/trunk/src/gnome/gnc-budget-view.c 2013-09-17 23:26:10 UTC > > (rev 23174) +++ gnucash/trunk/src/gnome/gnc-budget-view.c 2013-09-18 > > 09:40:44 UTC (rev 23175) @@ -1007,6 +1007,7 @@ > > GtkTreeViewColumn *col; > > GList *col_list; > > GList *totals_col_list; > > + ENTER("view %p", view); > > > > g_return_if_fail(view != NULL); > > priv = GNC_BUDGET_VIEW_GET_PRIVATE(view); > > @@ -1058,7 +1059,7 @@ > > col = gbv_create_totals_column(view, num_periods_visible); > > if (col != NULL) > > { > > - gtk_tree_view_append_column(priv->totals_tree_view, col); > > + /*gtk_tree_view_append_column(priv->totals_tree_view, > > col);*/ totals_col_list = g_list_append(totals_col_list, col); } > > > > If they aren't needed, can you remove the line completely instead of just > commenting them out > ? That leaves us with both better functioning and easier to read code. > > > @@ -1077,10 +1078,11 @@ > > col = gbv_create_totals_column(view, -1); > > if (col != NULL) > > { > > - gtk_tree_view_append_column(priv->totals_tree_view, col); > > + /*gtk_tree_view_append_column(priv->totals_tree_view, > > col);*/ } > > } > > Same here. > > Geert > _______________________________________________ Hi Geert Yep, I just applied the patch as is, I'll remove the comments. Mike Evans -- Please remember to CC this list on all your replies. You can do this by using Reply-To-List or Reply-All. _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel