On Sat Nov 26 18:47:16 EST 2022 Frank H. Ellenberger wrote:
nice to see you thinking a step further. But at first I have a
question: Why was it renamed from TSX to TMX?
From what I read in wikipedia the owner renamed itself a decade ago
but not the market.
One of the maintainers changed the name of the module and the methods
function when fixing it to account for the URL change in December 2020.
* Original *
sub methods {
return ( tsx => \&tsx,
canada => \&tsx );
}
* Current *
sub methods {
return ( tmx => \&tmx,
canada => \&tmx );
}
Personally I have no preference on the fix, but I'm thinking that
changing the function to the following will address the issue.
sub methods {
return ( tmx => \&tmx,
tsx => \&tmx,
canada => \&tmx );
}
Gord, if you would like to do a quick mod and test and open another PR
if it works, that would be appreciated. If not, I will see if I have
time. I want to wrap up the few issues and PRs open and release F::Q
v1.54 before the Christmas and New Years holidays if possible.
Also ISO 10383 https://www.iso20022.org/market-identifier-codes has
it still as TSX.
I would prefer, if the F::Q modules —where applicable— would follow
this standard.
It is is something that should be a guideline. Unfortunately, most of
the non-US exchanges are contributions from people outside of the main
F::Q team. While those contributions are reviewed to ensure they work,
usually checking against common identifiers is not done.
- Bruce S.
_______________________________________________
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
