[
https://issues.apache.org/jira/browse/HIVE-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702381#action_12702381
]
Ashish Thusoo commented on HIVE-192:
------------------------------------
Hi Shyam,
1. About unit tests, you should not have to play with velocity at all to add a
new test. You can just add a xyz.q file with the query in
ql/test/queries/clientpositive directory and in ql/test/queries/clientnegative
directory. And you can capture the test results by
ant -lib testlibs clean-test test -Dtestcase=TestCliDriver -Dqfile=xyz.q
-Doverwrite=true
for positive tests and
ant -lib testlibs clean-test test -Dtestcase=TestNegativeCliDriver
-Dqfile=xyzneg.q -Doverwrite=true
and then run these tests again after removing the -Doverwrite part and after
checking the results in the associated .q.out file formed in ql/test/results...
directory. Will add these instructions to the Developer Guide.
2. Native timestamp support in thrift would help a lot to be able to support
timestamps with thrift base serdes. Note that with zheng's work on lazy serdes
we would remove the dependency on thrift for serializing and deserializing
data. So at this point we should just say that TIMESTAMPS are not supported
with thrift serde. On the use of thrift on as a client server transport, there
should not be any issue as any data passing that boundary is also
serialized/deserialized using serdes.
> Cannot create table with timestamp type column
> ----------------------------------------------
>
> Key: HIVE-192
> URL: https://issues.apache.org/jira/browse/HIVE-192
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.2.0
> Reporter: Johan Oskarsson
> Fix For: 0.4.0
>
> Attachments: create_2.q.txt, TIMESTAMP_specification.txt
>
>
> create table something2 (test timestamp);
> ERROR: DDL specifying type timestamp which has not been defined
> java.lang.RuntimeException: specifying type timestamp which has not been
> defined
> at
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.FieldType(thrift_grammar.java:1879)
> at
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Field(thrift_grammar.java:1545)
> at
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.FieldList(thrift_grammar.java:1501)
> at
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Struct(thrift_grammar.java:1171)
> at
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.TypeDefinition(thrift_grammar.java:497)
> at
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Definition(thrift_grammar.java:439)
> at
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Start(thrift_grammar.java:101)
> at
> org.apache.hadoop.hive.serde2.dynamic_type.DynamicSerDe.initialize(DynamicSerDe.java:97)
> at
> org.apache.hadoop.hive.metastore.MetaStoreUtils.getDeserializer(MetaStoreUtils.java:180)
> at org.apache.hadoop.hive.ql.metadata.Table.initSerDe(Table.java:141)
> at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:202)
> at org.apache.hadoop.hive.ql.exec.DDLTask.createTable(DDLTask.java:641)
> at org.apache.hadoop.hive.ql.exec.DDLTask.execute(DDLTask.java:98)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:215)
> at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:174)
> at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:207)
> at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:305)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
