[ 
https://issues.apache.org/jira/browse/HIVE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721169#action_12721169
 ] 

Min Zhou commented on HIVE-521:
-------------------------------

I didn't  think all tests would pass due to the shortage of a class 
BinaryComparable. The reason why failing has nothing to do with this jira.  you 
can check out the trunk,and do 
ant -Dhadoop.version=0.17.0 test -Doverwrite=true
then error message will be displayed.
...
    [junit] Exception: org/apache/hadoop/io/BinaryComparable
    [junit] java.lang.NoClassDefFoundError: 
org/apache/hadoop/io/BinaryComparable
    [junit]     at java.lang.Class.getDeclaredConstructors0(Native Method)
    [junit]     at 
java.lang.Class.privateGetDeclaredConstructors(Class.java:2389)
    [junit]     at java.lang.Class.getConstructor0(Class.java:2699)
    [junit]     at java.lang.Class.newInstance0(Class.java:326)
    [junit]     at java.lang.Class.newInstance(Class.java:308)
    [junit]     at 
org.apache.hadoop.hive.ql.exec.FunctionRegistry.getUDFMethod(FunctionRegistry.java:309)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory$DefaultExprProcessor.getFuncExprNodeDesc(TypeCheckProcFactory.java:451)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory$DefaultExprProcessor.getXpathOrFuncExprNodeDesc(TypeCheckProcFactory.java:558)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory$DefaultExprProcessor.process(TypeCheckProcFactory.java:653)
    [junit]     at 
org.apache.hadoop.hive.ql.lib.DefaultRuleDispatcher.dispatch(DefaultRuleDispatcher.java:80)
    [junit]     at 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.dispatch(DefaultGraphWalker.java:83)
    [junit]     at 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.walk(DefaultGraphWalker.java:116)
    [junit]     at 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.startWalking(DefaultGraphWalker.java:95)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genExprNodeDesc(SemanticAnalyzer.java:3922)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genFilterPlan(SemanticAnalyzer.java:1000)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genFilterPlan(SemanticAnalyzer.java:986)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genBodyPlan(SemanticAnalyzer.java:3163)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:3610)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:3840)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:76)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.ExplainSemanticAnalyzer.analyzeInternal(ExplainSemanticAnalyzer.java:44)
    [junit]     at 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:76)
    [junit]     at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:177)
    [junit]     at org.apache.hadoop.hive.ql.Driver.run(Driver.java:209)
    [junit]     at 
org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:176)
    [junit]     at 
org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:216)
    [junit]     at 
org.apache.hadoop.hive.ql.QTestUtil.executeClient(QTestUtil.java:471)
    [junit]     at 
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_case_sensitivity(TestCliDriver.java:726)
    [junit]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [junit]     at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    [junit]     at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    [junit]     at java.lang.reflect.Method.invoke(Method.java:597)
    [junit]     at junit.framework.TestCase.runTest(TestCase.java:154)
    [junit]     at junit.framework.TestCase.runBare(TestCase.java:127)
    [junit]     at junit.framework.TestResult$1.protect(TestResult.java:106)
    [junit]     at junit.framework.TestResult.runProtected(TestResult.java:124)
    [junit]     at junit.framework.TestResult.run(TestResult.java:109)
    [junit]     at junit.framework.TestCase.run(TestCase.java:118)
    [junit]     at junit.framework.TestSuite.runTest(TestSuite.java:208)
    [junit]     at junit.framework.TestSuite.run(TestSuite.java:203)
    [junit]     at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:297)
    [junit]     at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:672)
    [junit]     at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:567)
    [junit] Caused by: java.lang.ClassNotFoundException: 
org.apache.hadoop.io.BinaryComparable
    [junit]     at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
    [junit]     at java.security.AccessController.doPrivileged(Native Method)
    [junit]     at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
    [junit]     at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
    [junit]     at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:276)
    [junit]     at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
    [junit]     at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
    [junit]     ... 43 more

> Move size, if, isnull, isnotnull to GenericUDF
> ----------------------------------------------
>
>                 Key: HIVE-521
>                 URL: https://issues.apache.org/jira/browse/HIVE-521
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Zheng Shao
>            Assignee: Min Zhou
>             Fix For: 0.4.0
>
>         Attachments: HIVE-521-all-v1.patch, HIVE-521-all-v2.patch, 
> HIVE-521-all-v3.patch, HIVE-521-all-v4.patch, HIVE-521-all-v5.patch, 
> HIVE-521-all-v6.patch, HIVE-521-IF-2.patch, HIVE-521-IF-3.patch, 
> HIVE-521-IF-4.patch, HIVE-521-IF-5.patch, HIVE-521-IF.patch, 
> keyword_targeted__ctr__imps.xlsx
>
>
> See HIVE-511 for an example of the move.
> size, if, isnull, isnotnull are all implemented with UDF but they are 
> actually working on variable types of objects. We should move them to 
> GenericUDF for better type handling.
> This also helps to clean up the hack in doing type matching/type conversion 
> in UDF.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to