On Tue, 2015-12-29 at 09:22 +0100, Philippe Mouawad wrote: > Hello Oleg, > Thanks for answer. > Could you elaborate a bit more on your answer ? > > Also, is there a chance that you fix the issue also in deprecated code of > httpclient (org.apache.http.conn.ssl.SSLSocketFactory) or is it too complex > ? >
I personally see no point in fixing non-critical bugs in deprecated code. This time can be better spent elsewhere. However I can commit a fix though if contributed. Oleg > Thanks > > On Wednesday, December 23, 2015, Oleg Kalnichevski <ol...@apache.org> wrote: > > > On Wed, 2015-12-23 at 14:30 +0100, Philippe Mouawad wrote: > > > Hi, > > > Any answer on the 1/ question ? > > > Thanks > > > Regards > > > > > > On Tue, Dec 22, 2015 at 2:39 PM, Philippe Mouawad < > > > philippe.moua...@gmail.com <javascript:;>> wrote: > > > > > > > Hi, > > > > With further investigation, I answered to some of my questions. > > > > > > > > Regards > > > > > > > > On Mon, Dec 21, 2015 at 6:52 PM, Philippe Mouawad < > > > > philippe.moua...@gmail.com <javascript:;>> wrote: > > > > > > > >> Hello, > > > >> Looking at: > > > >> > > > >> - https://issues.apache.org/jira/browse/HTTPCLIENT-1119 > > > >> > > > >> > > > >> 1/ It is not clear for me how the fix works if commit association is > > > >> correct: > > > >> > > > >> - > > https://fisheye6.atlassian.com/changelog/httpcomponents?cs=1544769 > > > >> > > > >> Is the fix about replacing: > > > >> > > > >> final SSLSocket sock = (SSLSocket) this.socketfactory.createSocket(); > > > >> > > > >> with : > > > >> SocketFactory.getDefault().createSocket(); > > > > Pretty much. Please note though that the use of a plain socket instead > > of a fully initialized SSL socket causes a different execution path in > > #connectSocket method. > > > > Oleg > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org For additional commands, e-mail: httpclient-users-h...@hc.apache.org
