And I just realized I need to remove the exit 2, because this will make openvpn 
exit.

Can I get +1s to this change to the script?



commit 50511a65e7dbdf0a60ad1cc43a6fa2fddec66ed3
Author: Patrick Uiterwijk <puiterw...@redhat.com>
Date:   Fri Oct 23 02:41:01 2015 +0000

    Make fix-routes not terminate with status 2 if it fixed it
    
    This will make openvpn think something went wrong and terminate the 
connection.
    I did this to make it easily visible when running with ansible, but in this 
case
    it messes things up.
    
    Signed-off-by: Patrick Uiterwijk <puiterw...@redhat.com>

diff --git a/roles/openvpn/client/files/fix-routes.sh 
b/roles/openvpn/client/files/fix-routes.sh
index a08e519..44a9450 100644
--- a/roles/openvpn/client/files/fix-routes.sh
+++ b/roles/openvpn/client/files/fix-routes.sh
@@ -8,5 +8,5 @@ then
        # 2. Add a new route to 192.168.0.0/16 via that IP addres (from xargs 
on)
        # 3. Print "Fixed VPN" and exit with code 2 to indicate that it changed
        # Note: I've been told that the grep and awk can be in one command, and 
I believe that, but I find this clearer.
-       (ip route show | grep '192.168.0.0/16') || ((ip route show | grep 
'192.168.0.' | awk '{print $1}' | xargs ip route add 192.168.0.0/16 via) && 
echo "Fixed VPN" && exit 2);
+       (ip route show | grep '192.168.0.0/16') || ((ip route show | grep 
'192.168.0.' | awk '{print $1}' | xargs ip route add 192.168.0.0/16 via) && 
echo "Fixed VPN");
 fi
_______________________________________________
infrastructure mailing list
infrastructure@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/infrastructure@lists.fedoraproject.org

Reply via email to