[ 
https://issues.apache.org/jira/browse/CALCITE-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813889#comment-17813889
 ] 

Alessandro Solimando commented on CALCITE-6237:
-----------------------------------------------

Calcite is a powerful but complex SW, there will always be weak spots in your 
knowledge: see how many times committers and PMC members ask for a second 
opinion or admit they are not very familiar with a certain area.

Knowledge will increase over time, but there is much more to it, like 
describing your problem clearly and at the right abstraction level, providing 
the needed context for others to understand your proposal/bug, backing up your 
hypotheses with facts, being able to look up in the history if anything is 
related and take it into consideration, splitting complex issues into simpler 
ones (and creating minimal reproducers), how to interact with people, and I am 
surely forgetting something along the way.

At first, one thinks that only contributing code matters, but it's way easier 
to build those skills by a mix of contributions, reviews of work from others 
and carefully following discussions on Jira and the ML.

No need to be anxious, all feedback is precious and meant to help you becoming 
a better contributor. In a volunteer-based project nobody invests time 
providing feedback if they don't see enough effort or the chance to improve, so 
don't lose your motivation and keep and keep pushing.

Hth,
Alessandro

> Using fractions in LOG function does not return correct results
> ---------------------------------------------------------------
>
>                 Key: CALCITE-6237
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6237
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.36.0
>            Reporter: Caican Cai
>            Priority: Major
>             Fix For: 1.37.0
>
>
> {code:java}
> mysql> SELECT LOG10(2/3) AS result;
> +---------------------+
> | result              |
> +---------------------+
> | -0.1760912594899757 |
> +---------------------+
> 1 row in set (0.00 sec)
> mysql> SELECT LOG2(0) AS result;
> +--------+
> | result |
> +--------+
> |   NULL |
> +--------+
> 1 row in set, 1 warning (0.01 sec)
> mysql> SELECT LOG2(2/3) AS result;
> +---------------------+
> | result              |
> +---------------------+
> | -0.5849625021638512 |
> +---------------------+
> 1 row in set (0.00 sec)
>   {code}
> When using Calcite's Log2 and Log10 functions, if the parameter is a 
> fraction, the integer digits will be retained by default. I think this is 
> wrong. Several decimal places (such as tens) should be retained by default.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to