Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2985#discussion_r241285610
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java
 ---
    @@ -663,6 +663,12 @@ public boolean hasNext() {
           return true;
         } else if (pageCounter < pageFilteredRowCount.length) {
           pageCounter++;
    +      if(pageCounter >= pageFilteredRowCount.length) {
    --- End diff --
    
    fillDataChunks calls freeDataChunkMemory(), but your changes skip this 
operation, i think "filteredRowCount == 0" has no problem, but the last page 
need call this method to free memory


---

Reply via email to