Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3000#discussion_r243132507
  
    --- Diff: 
datamap/bloom/src/main/java/org/apache/hadoop/util/bloom/CarbonBloomFilter.java 
---
    @@ -49,27 +49,23 @@ public CarbonBloomFilter(int vectorSize, int nbHash, 
int hashType, boolean compr
     
       @Override
       public boolean membershipTest(Key key) {
    -    if (key == null) {
    -      throw new NullPointerException("key cannot be null");
    -    }
    -
    -    int[] h = hash.hash(key);
    -    hash.clear();
         if (compress) {
           // If it is compressed check in roaring bitmap
    +      if (key == null) {
    --- End diff --
    
    got it


---

Reply via email to