Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3031#discussion_r244639643
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
---
@@ -140,6 +140,7 @@ public boolean isLocalDictGeneratedPage() {
} else {
actualDataColumnPage.putBytes(rowId, bytes);
}
+ pageSize = rowId + 1;
--- End diff --
So we need to update the pageSize each time we put a row to the page? It is
so waste of calculation.
Please reconsider the implementation.
---
