Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3055#discussion_r246277431
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/readers/SliceStreamReader.java
 ---
    @@ -142,5 +144,17 @@ public SliceStreamReader(int batchSize, DataType 
dataType,
     
       @Override public void reset() {
         builder = type.createBlockBuilder(null, batchSize);
    +    this.isLocalDict = false;
    +  }
    +
    +  @Override public void putInt(int rowId, int value) {
    +    Object data = DataTypeUtil
    --- End diff --
    
    Direct overriding does not create problem to local dictionary? how do you 
handle local dictionary here?


---

Reply via email to