[GitHub] carbondata pull request #3059: [HOTFIX][DataLoad]fix task assignment issue u...

[qiuchenjian]

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3059#discussion_r246352937
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
 ---
    @@ -609,6 +609,14 @@ public static Dictionary 
getDictionary(AbsoluteTableIdentifier absoluteTableIden
               blockAssignmentStrategy = 
BlockAssignmentStrategy.BLOCK_SIZE_FIRST;
             } else {
               blockAssignmentStrategy = 
BlockAssignmentStrategy.BLOCK_NUM_FIRST;
    +          // fall back to BLOCK_NUM_FIRST strategy need to reset
    +          // the average expected size for each node
    +          if (blockInfos.size() > 0) {
    --- End diff --
    
    ```suggestion
              if (numOfNodes > 0) {
    ```
    if  blockInfos.size() = 0 ， sizePerNode will be 0， so no need to add if 
... else ... 
    Do numOfNodes need to consider be 0?  


---