Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3063#discussion_r246973842
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -1364,6 +1365,29 @@ public int getHeapMemoryPoolingThresholdBytes() {
         return thresholdSize;
       }
     
    +  public int getRangeColumnScaleFactor() {
    +    boolean isValid = true;
    +    int scaleFactor = 1;
    +    try {
    +      scaleFactor = 
Integer.parseInt(CarbonProperties.getInstance().getProperty(
    +          CarbonCommonConstants.CARBON_RANGE_COLUMN_SCALE_FACTOR,
    +          CarbonCommonConstants.CARBON_RANGE_COLUMN_SCALE_FACTOR_DEFAULT));
    +      if (scaleFactor < 1 || scaleFactor > 300) {
    +        isValid = false;
    +      }
    +    } catch (NumberFormatException ex) {
    +      isValid = false;
    --- End diff --
    
    better to add a log to record exception or scaleFactor < 1 || scaleFactor > 
300


---

Reply via email to