[
https://issues.apache.org/jira/browse/FLINK-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057665#comment-16057665
]
ASF GitHub Bot commented on FLINK-6965:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4160
{FLINK-6965] Include snappy-java in flink-dist
This PR adds removes the snappy dependency exclusion from flink-core.
Without this dependency Flink components that work with avro, and thus
potentially snappy, fail when loading snappy. This also happens if snappy is
provided in the user-jar since the flink component doesn't use the user class
loader.
To prevent this dependency from being removed again in the future by
accident i modified `checkShadedArtifacts()` function in the travis scripts to
check for the presence of the dependency.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6965
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4160
----
commit f0e757776c45382cfc28daefe321d819d5a4a75c
Author: zentol <ches...@apache.org>
Date: 2017-06-21T14:18:34Z
{FLINK-6965] Include snappy-java in flink-dist
----
> Avro is missing snappy dependency
> ---------------------------------
>
> Key: FLINK-6965
> URL: https://issues.apache.org/jira/browse/FLINK-6965
> Project: Flink
> Issue Type: Bug
> Components: Type Serialization System
> Affects Versions: 1.3.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.3.2
>
>
> The shading rework made before 1.3 removed a snappy dependency that was
> accidentally pulled in through hadoop. This is technically alright, until
> class-loaders rear their ugly heads.
> Our kafka connector can read avro records, which may or may not require
> snappy. Usually this _should_ be solvable by including the snappy dependency
> in the user-jar if necessary, however since the kafka connector loads classes
> that it requires using the system class loader this doesn't work.
> As such we have to add a separate snappy dependency to flink-core.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
