[
https://issues.apache.org/jira/browse/FLINK-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166294#comment-16166294
]
ASF GitHub Bot commented on FLINK-7618:
---------------------------------------
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/4669
Thanks @sunjincheng121 but we cannot merge this without tests. Adding a new
type should have some tests esp. because you have to add this type at different
positions. E.g. `FlinkRelNode` and in the code generator as well.
> Add BINARY supported in FlinkTypeFactory
> ----------------------------------------
>
> Key: FLINK-7618
> URL: https://issues.apache.org/jira/browse/FLINK-7618
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> We will get the following exception when we deal with the BINARY type.
> {code}
> org.apache.flink.table.api.TableException: Type is not supported: BINARY
> at org.apache.flink.table.api.TableException$.apply(exceptions.scala:53)
> at
> org.apache.flink.table.calcite.FlinkTypeFactory$.toTypeInfo(FlinkTypeFactory.scala:377)
> at
> org.apache.flink.table.codegen.CodeGenerator.visitCall(CodeGenerator.scala:741)
> at
> org.apache.flink.table.codegen.CodeGenerator.visitCall(CodeGenerator.scala:67)
> at org.apache.calcite.rex.RexCall.accept(RexCall.java:104)
> at
> org.apache.flink.table.codegen.CodeGenerator$$anonfun$16.apply(CodeGenerator.scala:754)
> at
> org.apache.flink.table.codegen.CodeGenerator$$anonfun$16.apply(CodeGenerator.scala:744)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
