Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138899420 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java --- @@ -218,7 +221,7 @@ public long addRecord(T record) throws IOException { return offset; } - public MutableObjectIterator<T> finishWriteAndSortKeys(List<MemorySegment> memory) throws IOException { + public MutableObjectIterator<T> finishWriteAndSortKeys(List<MemorySegment> memory) throws IOException, IllegalAccessException, TemplateException, InstantiationException, CompileException, InvocationTargetException, NoSuchMethodException, ClassNotFoundException { --- End diff -- I'm thinking that we should encapsulate all these exceptions into one `SorterCodegenException` (or just `CodegenException`) and throw only that from the sorter factory method, to avoid having to declare this litany of exceptions (this same list occurs at multiple places).
---