[
https://issues.apache.org/jira/browse/FLINK-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242460#comment-16242460
]
ASF GitHub Bot commented on FLINK-7991:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4975
[FLINK-7991][examples][kafka] Cleanup kafka10 example jar
## What is the purpose of the change
This PR cleans up the kafka example shading configuration, removing plenty
of unnecessary classes from the resulting jar along with several ineffective
inclusions.
## Brief change log
* remove inclusions for zk, curator, jute, I0Itex, jline and jammer as they
are ineffective
* narrow down `org.apache.flink.streaming` inclusion to only include the
kafka connector
## Verifying this change
* Build jar before and after and compare contents
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7991
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4975.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4975
----
commit cca79f8194ab46aab51f5dfb2f528802a9fbb9d4
Author: zentol <ches...@apache.org>
Date: 2017-11-07T17:12:29Z
[FLINK-7991][examples][kafka] Cleanup kafka10 example jar
----
> Cleanup kafka example jar filters
> ---------------------------------
>
> Key: FLINK-7991
> URL: https://issues.apache.org/jira/browse/FLINK-7991
> Project: Flink
> Issue Type: Bug
> Components: Examples
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0, 1.5.0
>
>
> The kafka example jar shading configuration includes the following files:
> {code}
> <include>org/apache/flink/streaming/examples/kafka/**</include>
> <include>org/apache/flink/streaming/**</include>
> <include>org/apache/kafka/**</include>
> <include>org/apache/curator/**</include>
> <include>org/apache/zookeeper/**</include>
> <include>org/apache/jute/**</include>
> <include>org/I0Itec/**</include>
> <include>jline/**</include>
> <include>com/yammer/**</include>
> <include>kafka/**</include>
> {code}
> Problems:
> * the inclusion of org.apache.flink.streaming causes large parts of the API
> (and runtime...) to be included in the jar, along the _Twitter_ source and
> *all* other examples
> * the yammer, jline, l0ltec, jute, zookeeper and curator inclusions are
> ineffective; none of these classes show up in the example jar
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
