[
https://issues.apache.org/jira/browse/FLINK-8004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242875#comment-16242875
]
ASF GitHub Bot commented on FLINK-8004:
---------------------------------------
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4965
LGTM.
> Sample code in Debugging & Monitoring Metrics documentation section is not
> valid java
> --------------------------------------------------------------------------------------
>
> Key: FLINK-8004
> URL: https://issues.apache.org/jira/browse/FLINK-8004
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, Metrics
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Andreas Hecke
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.4.0, 1.5.0
>
>
> Hi, we have been stumbled about some documentation inconsistencies in how to
> use metrics in flink. Seems there is some invalid java code posted as samples
> like having methods declared as @public and missing return statements, see
> [here|https://ci.apache.org/projects/flink/flink-docs-release-1.3/monitoring/metrics.html#counter]
> I raised a question on
> [SO|https://stackoverflow.com/questions/47153424/what-does-public-modifier-mean-in-method-signature]
> and Fabian asked me to open a Jira issue
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
