Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4980#discussion_r149993559
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
 ---
    @@ -277,8 +287,12 @@ public void invoke() throws Exception {
                                }
                        }
     
    -                   triggerLatch.trigger();
                        if (error != null) {
    +                           // exit method prematurely due to error but 
make sure that the tests can finish
    +                           triggerLatch.trigger();
    --- End diff --
    
    yes, a latch that was already triggered will simply return immediately, no 
need for an additional check



---

Reply via email to